Makecache improvements #186
Conversation
I was going to change this to use "exec", but realized that the current behavior may be somewhat intentional. Document it.
In the case of an upgraded system from Fedora 20 where dnf wasn't installed, and the user continues to use yum (or PackageKit), we'll be pointlessly downloading metadata even if dnf is not in use. See: https://lists.fedoraproject.org/pipermail/devel/2014-December/205506.html Reported-by: Hedayat Vatankhah <hedayat.fwd@gmail.com>
|
My impression is that this file is not used anymore. I'm about to close the pull request and delete the file. @cgwalters, did I miss something? Moreover, I think the "Only run if we have a cache at all" change is not needed. If DNF will be accepted as the default, the change wouldn't solve anything then. So the change is useful only for Fedora 21 where the problem can be worked around by removing DNF. The change also is not very systematic since a user can even by accident run DNF for the first time and then the problem is back again. |
|
Right, looks like As far as the concept, there is the case of users who never touch commandline packaging and only use GNOME Software - in that case, the dnf cache is not used. But I don't have a really strong opinion myself, it's clear long term that we'll need a better unified caching story. |
ghost
self-assigned this
|
OK, we'll discuss whether we can come up with a better solution for users that (almost) never use DNF. (We should also take into account the other applications that uses DNF) We'll appreciate if someone files a Bugzilla for that so we can close this PR and track it in Bugzilla. |
Two patches for makecache (not actually tested, but they're pretty simple...)