Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for environmental groups install / remove / upgrade #585

Merged
merged 8 commits into from
Jun 8, 2023

Conversation

m-blaha
Copy link
Member

@m-blaha m-blaha commented Jun 1, 2023

With this patch all dnf5 group subcommands can also handle environmental groups.

Requires: #554
Resolves: #367

// Remove groups installed by the environment in case they are installed
// as dependencies and are not part of another installed environment.
for (const auto & grp : environment_groups) {
// is the package part of another group which is not being removed?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// is the package part of another group which is not being removed?
// is the group part of another environment which is not being removed?

libdnf/base/goal.cpp Show resolved Hide resolved
libdnf/base/goal.cpp Outdated Show resolved Hide resolved
Returns list of installed environments a given group is part of.
For the compatibility reasons we need to handle situation when the group
spec is actually an environment.
Environmental groups are supported by both `dnf5 group install <spec>`
and `dnf5 install @spec` commands.
In kickstart files the environmental groups are stored as
`@^environment`. This patch adds support for using the same sytax also
for dnf commands, e.g. `dnf5 install @^environment`.
Given that the action is also used for installing groups via
environments, let's use more general action name.
@m-blaha m-blaha force-pushed the mblaha/environments-install branch from a57661a to ea710c1 Compare June 7, 2023 10:27
Copy link
Contributor

@kontura kontura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kontura kontura added this pull request to the merge queue Jun 8, 2023
Merged via the queue into main with commit 05ae41f Jun 8, 2023
@kontura kontura deleted the mblaha/environments-install branch June 8, 2023 04:42
mkrizek added a commit to mkrizek/ansible that referenced this pull request Jun 12, 2023
bcoca pushed a commit to ansible/ansible that referenced this pull request Jun 13, 2023
mkrizek added a commit to mkrizek/ansible that referenced this pull request Jun 14, 2023
nitzmahone pushed a commit to ansible/ansible that referenced this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

add_install(environment) doesn't appear to be working.
2 participants