Support for environmental groups install / remove / upgrade #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontura
reviewed
Jun 6, 2023
libdnf/base/goal.cpp
Outdated
| // Remove groups installed by the environment in case they are installed | ||
| // as dependencies and are not part of another installed environment. | ||
| for (const auto & grp : environment_groups) { | ||
| // is the package part of another group which is not being removed? |
There was a problem hiding this comment.
Suggested change
| // is the package part of another group which is not being removed? | |
| // is the group part of another environment which is not being removed? |
This was referenced Jun 6, 2023
Returns list of installed environments a given group is part of.
For the compatibility reasons we need to handle situation when the group spec is actually an environment.
Environmental groups are supported by both `dnf5 group install <spec>` and `dnf5 install @spec` commands.
In kickstart files the environmental groups are stored as `@^environment`. This patch adds support for using the same sytax also for dnf commands, e.g. `dnf5 install @^environment`.
Given that the action is also used for installing groups via environments, let's use more general action name.
m-blaha
force-pushed
the
mblaha/environments-install
branch
from
a57661a
to
ea710c1
Compare
mkrizek
added a commit
to mkrizek/ansible
that referenced
this pull request
Jun 12, 2023
bcoca
pushed a commit
to ansible/ansible
that referenced
this pull request
Jun 13, 2023
mkrizek
added a commit
to mkrizek/ansible
that referenced
this pull request
Jun 14, 2023
Implemented in rpm-software-management/dnf5#585 (cherry picked from commit f13e35c)
nitzmahone
pushed a commit
to ansible/ansible
that referenced
this pull request
Jul 5, 2023
Implemented in rpm-software-management/dnf5#585 (cherry picked from commit f13e35c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch all
dnf5 groupsubcommands can also handle environmental groups.Requires: #554
Resolves: #367