repoquery: add --srpm and --sourcerpm #595
Conversation
|
Rebased. |
|
|
||
| if (querytags_option->get_value()) { | ||
| libdnf::cli::output::print_available_pkg_attrs(stdout); | ||
| } else if (changelogs->get_value()) { | ||
| libdnf::rpm::PackageQuery wrapped(result_pset); | ||
| libdnf::cli::output::print_changelogs(wrapped, full_package_query, false, 0, 0); | ||
| libdnf::cli::output::print_changelogs(full_package_query, full_package_query, false, 0, 0); |
There was a problem hiding this comment.
I was confused about this, because the second argument for print_changelogs changed during the move, but it doesn't have any effect... However, the query is then unnecessarily copied and filtered, so wouldn't it be better to pass an empty query or change it in the print_changelogs? Neither is necessary in this PR, though (it's actually smaller now than it was before).
There was a problem hiding this comment.
Yes, I agree. I tried to improve the print_changelogs in a new commit. Please take a look.
There was a problem hiding this comment.
Thanks. FYI, I encountered an unrelated issue with the changelog command (#627) when testing it. Just mentioning if you run into the same.
| *this, | ||
| "srpm", | ||
| '\0', | ||
| "For selected packages format corresponding source RPMs (enables source repositories).", |
There was a problem hiding this comment.
Hm, I don't understand the word "format" in this context. Previously, there was "operate on", which seems more intuitive, but maybe I am missing something?
There was a problem hiding this comment.
I tried to express that if the --srpm switch is applied we can only format (specify which information to show) the selected srpms but they won't be filtered anymore because all filtering is done before.
To me "operate on" suggest that we can apply also other options to the srpms. Although maybe I am overthinking this 🙂.
What about:
"After filtering is finished use packages' corresponding source RPMs for output (enables source repositories).",
There was a problem hiding this comment.
Well, other options are applied to the srpms - the query options. In dnf5, I don't see it in the documentation (at least not on the first glance), but there is info or the pkg_attrs_options (requires, provides...).
But I see what you mean and the "operate on" is not super clear either. The proposed sentence looks easier to understand.
It can speed up the repoquery run a lot if a pkg_spec is used.
The filters in `print_changelogs(...)` are exclusive, only one can be applied per call. This also means we don't have to pass in `PackageQuery` if it is not needed.
For: #122