Docs say not to use --offline, but not why

[ringerc]

The README.md says that --offline is intended to allow use of a local-only git repo without needing to hit a remote server for every action.

However, the asciidoc says:

--offline::
do not attempt any remote communication (avoid using
this please)

Why? Is this just outdated? Is there something broken that needs fixing?

[ringerc]

tito build --help includes the same text.

[dgoodwin]

Offline lets you potentially do builds you can't reproduce, normally we check that the tag you're building exists in the remote repo. If it hasn't been pushed, it's quite easy to do a build that will result in a checksum that is no longer the same. This is something we try to avoid.

[ringerc]

On 07/30/2014 10:31 PM, Devan Goodwin wrote:

Offline lets you potentially do builds you can't reproduce, normally we
check that the tag you're building exists in the remote repo. If it
hasn't been pushed, it's quite easy to do a build that will result in a
checksum that is no longer the same. This is something we try to avoid.

Ah, OK. So it works, but isn't recommended because it may lead to the
same tarball being produced with different checksums if the user hasn't
ensured everything's in sync with a central master repo.

Makes sense. It might be worth adding what you wrote above to the docs;
currently it's most unclear.

Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

[dgoodwin]

Yes absolutely, it's a bit longwinded for optparse help but it would be a good fit in man page.

[stevekuznetsov]

Fixed in xsuchy@f5f9e22