Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dino repo link to get correct repo #14

Closed
wants to merge 2 commits into from
Closed

Updated dino repo link to get correct repo #14

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 13, 2019

No description provided.

@kwizart
Copy link
Member

kwizart commented Dec 13, 2019

Does the $VERSION_ID will be resolved by fedy at install time or is it possible to use the $releasever variable in the repo definition so it will be adapted across Fedora version upgrade ?

@ghost
Copy link
Author

ghost commented Dec 13, 2019

I changed it, maybe better this way.

@ghost
Copy link
Author

ghost commented Dec 13, 2019

Not really, he ask for it everytime to push the install button from dino.

@kwizart
Copy link
Member

kwizart commented Dec 13, 2019

So I guess you still miss-understand why your patch is wrong ?

@ghost
Copy link
Author

ghost commented Dec 13, 2019 via email

@kwizart
Copy link
Member

kwizart commented Dec 13, 2019

$releasever is a special variable used in a repo url that will be evaluated to the appropriate fedora version whenever one decide to upgrade fedora.

There is no need to hit install again to have every single repository updated to the appropriate version. This will save errors when a more appropriate package is available for a newer fedora release.

@kwizart
Copy link
Member

kwizart commented Dec 16, 2019

Any update with the appropriate fix ?

@ghost
Copy link
Author

ghost commented Dec 17, 2019

I get it now.
I will work on a fix.

@kwizart
Copy link
Member

kwizart commented Jan 1, 2020

It looks like dino is in fedora. Fixed as appropriate in fedy 5.0.2
Thx for the report.

BTW, looking at using $releasever doesn't seem possible with dnf config-manager, we would need another hack (like using the current version and then patching the file to use releasever instead of a hardcoded version...).

@kwizart kwizart closed this Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant