Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

points in pts0_new (new keypoints in left camera) might be unexpectedly rejected because of out-of-bound points in pts1_new (keypoints in right camera) #332

Closed
NewThinker-Jeffrey opened this issue Apr 28, 2023 · 1 comment · Fixed by #337
Labels
bug Something isn't working

Comments

@NewThinker-Jeffrey
Copy link

Here is the relevant code:

if ((int)pts1_new.at(i).x < 0 || (int)pts1_new.at(i).x >= img1pyr.at(0).cols || (int)pts1_new.at(i).y < 0 ||

I suppose we always want to add those detected new points pts0_new to pts0 if they're in the bound, despite their matching result to the right image.
However this piece of code might reject some in-bound points in pts0_new because of others faults, i.e. out-of-bound ponits in pts1_new.

@goldbattle goldbattle added debugging Might be a bug, looking into the issue bug Something isn't working and removed debugging Might be a bug, looking into the issue labels May 4, 2023
@goldbattle
Copy link
Member

There is also a couple other bugs in the right stereo matching. I will push a public fix in a few days. Many thanks for the report.

goldbattle added a commit that referenced this issue May 10, 2023
… right image, fix mask updates for point extraction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants