Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking active tab makes tab inactive #10

Closed
tlvince opened this issue Feb 3, 2015 · 1 comment
Closed

Clicking active tab makes tab inactive #10

tlvince opened this issue Feb 3, 2015 · 1 comment

Comments

@tlvince
Copy link
Contributor

tlvince commented Feb 3, 2015

As per #7, I think this is unexpected behaviour as it differs to ui-bootstrap's behaviour; in ui-bootstrap, you cannot click a tab that's already active.

This happens because ui-bootstrap's behaviour is effectively overridden via the use of ui-sref.
@rpocklin
Copy link
Owner

rpocklin commented Feb 5, 2015

Ok, I think the correct behaviour is to disable the ui-sref in this case. Open to a different PR (see comments in PR...)

rpocklin added a commit that referenced this issue Feb 5, 2015
@rpocklin
Merge pull request #11 from tlvince/bug/active-inactive
752054b 
Switch tabs iif tab state is inactive, closes #10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tlvince @rpocklin