-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "import *" #67
Comments
I'm unassigning myself, because I don't know how to fix this. |
I'm trying to remove |
I've skimmed through it and ran the repository through the ruff linter. Looks good to me. |
@rpoleski I see that you started doing it in a specific branch. |
Dear @ketozhang, I've already forgotten about this discussion and branch linked above. There are multiple similar changes like: |
No, not if the file using the import statement lives inside the package. It's a stylistic preference (despite the misunderstood caution to avoid it) |
Thanks. |
It's a bad practice to do "import *" in python. It can be replaced using specific imports or using
__all__
in imported files. We should remove "import *" from__init__.py
andmulensobjects/__init__.py
.The text was updated successfully, but these errors were encountered: