Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CI to GitHub Actions, add testing for Rails 7.0 and Ruby 3.1 #33

Closed
aried3r opened this issue Mar 2, 2022 · 5 comments · Fixed by #42
Closed

Migrate CI to GitHub Actions, add testing for Rails 7.0 and Ruby 3.1 #33

aried3r opened this issue Mar 2, 2022 · 5 comments · Fixed by #42

Comments

@aried3r
Copy link
Member

aried3r commented Mar 2, 2022

Test on push and pull request events and perhaps once every month to find deprecations early. See also #32 which added redis deprecation warnings as errors.

Also add Rails 7 and Ruby 3.1 to CI.

@aried3r aried3r changed the title Migrate CI to GitHub Actions Migrate CI to GitHub Actions, add testing for Rails 7.0 and Ruby 3.1 Mar 2, 2022
benlangfeld added a commit to powerhome/modis that referenced this issue Jan 17, 2023
@benlangfeld
Copy link
Contributor

@aried3r I'd appreciate if you would enable GH actions for #34 or give me sufficient permissions to do so myself.

benlangfeld added a commit to powerhome/modis that referenced this issue Jan 17, 2023
@garettarrowood
Copy link
Collaborator

I have write access to modis, but I do not have the ability to enable Github actions nor give you more permissions to do so @benlangfeld . I would be in favor merging your additions and granting you that access level though.

@benlangfeld
Copy link
Contributor

@aried3r Can we make all of these write permission? https://github.com/orgs/rpush/teams/maintainers/repositories

Might you also nominate someone else to Core and give that team admin on modis (consistent with the other repos)?

@benlangfeld
Copy link
Contributor

@aried3r @ileitch I'm unable to make progress without your help with permissions.

@ileitch
Copy link
Member

ileitch commented Jan 31, 2023

Ive added you to Core and fixed the permissions. Thank you for continuing to work on these projects 🙌

benlangfeld added a commit to powerhome/modis that referenced this issue Feb 1, 2023
benlangfeld added a commit that referenced this issue Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants