Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Oracle support #185

Merged
merged 1 commit into from
Jul 28, 2015
Merged

Fix typo in Oracle support #185

merged 1 commit into from
Jul 28, 2015

Conversation

latortuga
Copy link
Contributor

No description provided.

@latortuga
Copy link
Contributor Author

I'm confident in this change because I put the following patch at the end of my Rpush initializer and everything is working with Oracle:

if Rpush::VERSION == '2.5.0'
  require 'rpush'
  require 'rpush/daemon'
  require 'rpush/daemon/store/active_record'

  module Rpush
    module Daemon
      module Store
        class ActiveRecord
          private

          def claim(relation)
            notifications = relation.lock(true).to_a
            @using_oracle ? notifications.sort_by(&:created_at) : notifications
          end
        end
      end
    end
  end
end

ileitch added a commit that referenced this pull request Jul 28, 2015
Fix typo in Oracle support
@ileitch ileitch merged commit ca77035 into rpush:master Jul 28, 2015
@ileitch
Copy link
Member

ileitch commented Jul 28, 2015

😱 oops!

@latortuga latortuga deleted the patch-2 branch July 28, 2015 17:03
Adrian1707 pushed a commit to Adrian1707/rpush that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants