Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ApnsFeedback only on Apns apps. #318

Merged
merged 1 commit into from
Dec 6, 2016
Merged

Conversation

robertasg
Copy link

Currently, ApnsFeedback tries running on every added application, including GCM for example. This results in a crash due to incompatible interfaces.

@amaierhofer
Copy link
Contributor

I do not think this is necessary.

Rpush::Apns::App.all already ensures that only Apns apps are considered when starting the Feedback Receiver.

@amaierhofer amaierhofer closed this Dec 2, 2016
@robertasg
Copy link
Author

Not on Redis. On Redis every App is on the same namespace defined in Rpush::Client::Redis::App.
Perhaps this can be solved with a different approach, eg. using different namespaces throughout the different apps to be more consistent.

@amaierhofer
Copy link
Contributor

amaierhofer commented Dec 2, 2016

Ahh I see, it's all legit :)

I would appreciate if you could rebase onto master, add a comment explaining that this is necessary when using Redis and add a line to the changelog file.

@amaierhofer
Copy link
Contributor

Great! Many thanks!

Adrian1707 pushed a commit to Adrian1707/rpush that referenced this pull request Apr 24, 2024
Run ApnsFeedback only on Apns apps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants