Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate enabling -Wall or -Werror #13

Closed
joneschrisg opened this issue May 7, 2013 · 2 comments
Closed

Investigate enabling -Wall or -Werror #13

joneschrisg opened this issue May 7, 2013 · 2 comments
Assignees
@joneschrisg

Comments

@joneschrisg
Copy link
Contributor

Generally a good idea, but rr's type of low-level code may result in so many meaningless warnings that the cost exceeds the benefit. But worth looking into eventually.
@ghost ghost assigned joneschrisg Jun 3, 2013
@joneschrisg
Copy link
Contributor Author

I've run into some scary-ish things that make me want this enabled sooner rather than later. -Werror isn't always a great idea, but with fast builds, 1+\epsilon regular contributors, and 1 supported compiler/OS combo, maybe it'll work for now.

joneschrisg added a commit that referenced this issue Jun 4, 2013
@joneschrisg
Merge pull request #82 from cgjones/werror-et-al
083a76e 
Build with -Werror (includes fixes for current warnings). Resolves #13
@joneschrisg
Copy link
Contributor Author

Ftr, this change has been nothing but candy and rainbows so far. Let's hope it keeps up for a while!

@benturner benturner mentioned this issue Aug 27, 2014
Closed
@qiankehan qiankehan mentioned this issue Nov 16, 2015
Closed
This was referenced Oct 13, 2016
Closed
Closed
@mjfroman mjfroman mentioned this issue Nov 7, 2016
Closed
@dcolascione dcolascione mentioned this issue Nov 28, 2016
Closed
@hotsphink hotsphink mentioned this issue Dec 28, 2016
Open
@tbsaunde tbsaunde mentioned this issue Apr 18, 2017
Closed
@tbsaunde tbsaunde mentioned this issue May 7, 2017
Closed
@hotsphink hotsphink mentioned this issue Jun 12, 2017
Closed
@dcolascione dcolascione mentioned this issue Feb 14, 2018
Open
@ghost ghost mentioned this issue Jan 7, 2019
Closed
@stransky stransky mentioned this issue Mar 24, 2020
Closed
@allstarschh allstarschh mentioned this issue Sep 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joneschrisg joneschrisg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joneschrisg