Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mode lines to sources #12

Merged
merged 1 commit into from
May 8, 2013
Merged

Add mode lines to sources #12

merged 1 commit into from
May 8, 2013

Conversation

joneschrisg
Copy link
Contributor

I'm not passing judgment on the current style, just documenting it for the sake of primitive editors. Judgment is a separate discussion ;).

Mechanical edits.

@andreasgal
Copy link
Contributor

The new occupant gets to make the rules. Feel free to dictate a new style guide.

andreasgal added a commit that referenced this pull request May 8, 2013
@andreasgal
Merge pull request #12 from cgjones/modelines-fixed
6144889 
Add mode lines to sources
@andreasgal andreasgal merged commit 6144889 into rr-debugger:master May 8, 2013
@benturner benturner mentioned this pull request Aug 27, 2014
Closed
@khuey khuey mentioned this pull request Feb 18, 2015
Closed
@qiankehan qiankehan mentioned this pull request Nov 16, 2015
Closed
This was referenced Oct 13, 2016
Closed
Closed
@mjfroman mjfroman mentioned this pull request Nov 7, 2016
Closed
@dcolascione dcolascione mentioned this pull request Nov 28, 2016
Closed
@hotsphink hotsphink mentioned this pull request Dec 28, 2016
Open
@tbsaunde tbsaunde mentioned this pull request Apr 18, 2017
Closed
@tbsaunde tbsaunde mentioned this pull request May 7, 2017
Closed
@hotsphink hotsphink mentioned this pull request Jun 12, 2017
Closed
@dcolascione dcolascione mentioned this pull request Feb 14, 2018
Open
@ghost ghost mentioned this pull request Jan 7, 2019
Closed
@stransky stransky mentioned this pull request Mar 24, 2020
Closed
@allstarschh allstarschh mentioned this pull request Sep 11, 2020
Closed
bernhardu added a commit to bernhardu/rr that referenced this pull request Apr 20, 2023
@bernhardu
Avoid assert which is now more likely after recent commit.
d89e065 
Related: 7ffb7d6
See issue 3504.

$ bin/rr record -n bin/pid_ns_kill_child

Error message:
  [FATAL src/Task.cc:2167:did_waitpid() errno: EDOM]
   (task 285229 (rec:285229) at time 269)
   -> Assertion `!handled_ptrace_exit_event' failed to hold.

rr-debugger#6  rr::EmergencyDebugOstream::~EmergencyDebugOstream (this=this@entry=0x7fffb7babb70, __in_chrg=<optimized out>) at rr/src/log.cc:484
rr-debugger#7  0x000056012f0b167d in rr::Task::did_waitpid (this=this@entry=0x56012f9d4640, status=...) at rr/src/Task.cc:2167
rr-debugger#8  0x000056012f086ac7 in rr::Scheduler::reschedule (this=this@entry=0x56012f9c4188, switchable=<optimized out>) at rr/src/Scheduler.cc:882
rr-debugger#9  0x000056012eff4607 in rr::RecordSession::record_step (this=0x56012f9c3f40) at rr/src/RecordSession.cc:2497
rr-debugger#10 0x000056012efe8664 in rr::record (flags=..., args=...) at rr/src/RecordCommand.cc:697
rr-debugger#11 rr::RecordCommand::run (this=0x56012f207a40 <rr::RecordCommand::singleton>, args=...) at rr/src/RecordCommand.cc:860
rr-debugger#12 0x000056012ef4800f in main (argc=<optimized out>, argv=<optimized out>) at rr/src/main.cc:278

With change in Task.cc:
Error message:
  [FATAL src/Task.cc:3894:did_handle_ptrace_exit_event()]
   (task 308641 (rec:308641) at time 269)
   -> Assertion `!handled_ptrace_exit_event' failed to hold.

rr-debugger#6  rr::EmergencyDebugOstream::~EmergencyDebugOstream (this=this@entry=0x7ffe5e4cdf70, __in_chrg=<optimized out>) at rr/src/log.cc:484
rr-debugger#7  0x000056265d0981b7 in rr::Task::did_handle_ptrace_exit_event (this=this@entry=0x56265dde3640) at rr/src/Task.cc:3894
rr-debugger#8  0x000056265cfdb110 in rr::handle_ptrace_exit_event (t=t@entry=0x56265dde3640) at rr/src/RecordSession.cc:279
rr-debugger#9  0x000056265cfe272b in rr::RecordSession::record_step (this=0x56265ddd2f40) at rr/src/RecordSession.cc:2535
rr-debugger#10 0x000056265cfd6674 in rr::record (flags=..., args=...) at rr/src/RecordCommand.cc:697
rr-debugger#11 rr::RecordCommand::run (this=0x56265d1f5a40 <rr::RecordCommand::singleton>, args=...) at rr/src/RecordCommand.cc:860
rr-debugger#12 0x000056265cf3601f in main (argc=<optimized out>, argv=<optimized out>) at rr/src/main.cc:278
bernhardu added a commit to bernhardu/rr that referenced this pull request Apr 21, 2023
@bernhardu
Avoid assert which is now more likely after recent commit.
8777a43 
Related: 7ffb7d6
See issue 3504.

$ bin/rr record -n bin/pid_ns_kill_child

Error message:
  [FATAL src/Task.cc:2167:did_waitpid() errno: EDOM]
   (task 285229 (rec:285229) at time 269)
   -> Assertion `!handled_ptrace_exit_event' failed to hold.

rr-debugger#6  rr::EmergencyDebugOstream::~EmergencyDebugOstream (this=this@entry=0x7fffb7babb70, __in_chrg=<optimized out>) at rr/src/log.cc:484
rr-debugger#7  0x000056012f0b167d in rr::Task::did_waitpid (this=this@entry=0x56012f9d4640, status=...) at rr/src/Task.cc:2167
rr-debugger#8  0x000056012f086ac7 in rr::Scheduler::reschedule (this=this@entry=0x56012f9c4188, switchable=<optimized out>) at rr/src/Scheduler.cc:882
rr-debugger#9  0x000056012eff4607 in rr::RecordSession::record_step (this=0x56012f9c3f40) at rr/src/RecordSession.cc:2497
rr-debugger#10 0x000056012efe8664 in rr::record (flags=..., args=...) at rr/src/RecordCommand.cc:697
rr-debugger#11 rr::RecordCommand::run (this=0x56012f207a40 <rr::RecordCommand::singleton>, args=...) at rr/src/RecordCommand.cc:860
rr-debugger#12 0x000056012ef4800f in main (argc=<optimized out>, argv=<optimized out>) at rr/src/main.cc:278

With change in Task.cc:
Error message:
  [FATAL src/Task.cc:3894:did_handle_ptrace_exit_event()]
   (task 308641 (rec:308641) at time 269)
   -> Assertion `!handled_ptrace_exit_event' failed to hold.

rr-debugger#6  rr::EmergencyDebugOstream::~EmergencyDebugOstream (this=this@entry=0x7ffe5e4cdf70, __in_chrg=<optimized out>) at rr/src/log.cc:484
rr-debugger#7  0x000056265d0981b7 in rr::Task::did_handle_ptrace_exit_event (this=this@entry=0x56265dde3640) at rr/src/Task.cc:3894
rr-debugger#8  0x000056265cfdb110 in rr::handle_ptrace_exit_event (t=t@entry=0x56265dde3640) at rr/src/RecordSession.cc:279
rr-debugger#9  0x000056265cfe272b in rr::RecordSession::record_step (this=0x56265ddd2f40) at rr/src/RecordSession.cc:2535
rr-debugger#10 0x000056265cfd6674 in rr::record (flags=..., args=...) at rr/src/RecordCommand.cc:697
rr-debugger#11 rr::RecordCommand::run (this=0x56265d1f5a40 <rr::RecordCommand::singleton>, args=...) at rr/src/RecordCommand.cc:860
rr-debugger#12 0x000056265cf3601f in main (argc=<optimized out>, argv=<optimized out>) at rr/src/main.cc:278
bernhardu added a commit to bernhardu/rr that referenced this pull request Apr 21, 2023
@bernhardu
Avoid assert which is now more likely after recent commit.
3515662 
Related: 7ffb7d6
See issue 3504.

$ bin/rr record -n bin/pid_ns_kill_child

Error message:
  [FATAL src/Task.cc:2167:did_waitpid() errno: EDOM]
   (task 285229 (rec:285229) at time 269)
   -> Assertion `!handled_ptrace_exit_event' failed to hold.

rr-debugger#6  rr::EmergencyDebugOstream::~EmergencyDebugOstream (this=this@entry=0x7fffb7babb70, __in_chrg=<optimized out>) at rr/src/log.cc:484
rr-debugger#7  0x000056012f0b167d in rr::Task::did_waitpid (this=this@entry=0x56012f9d4640, status=...) at rr/src/Task.cc:2167
rr-debugger#8  0x000056012f086ac7 in rr::Scheduler::reschedule (this=this@entry=0x56012f9c4188, switchable=<optimized out>) at rr/src/Scheduler.cc:882
rr-debugger#9  0x000056012eff4607 in rr::RecordSession::record_step (this=0x56012f9c3f40) at rr/src/RecordSession.cc:2497
rr-debugger#10 0x000056012efe8664 in rr::record (flags=..., args=...) at rr/src/RecordCommand.cc:697
rr-debugger#11 rr::RecordCommand::run (this=0x56012f207a40 <rr::RecordCommand::singleton>, args=...) at rr/src/RecordCommand.cc:860
rr-debugger#12 0x000056012ef4800f in main (argc=<optimized out>, argv=<optimized out>) at rr/src/main.cc:278

With change in Task.cc:
Error message:
  [FATAL src/Task.cc:3894:did_handle_ptrace_exit_event()]
   (task 308641 (rec:308641) at time 269)
   -> Assertion `!handled_ptrace_exit_event' failed to hold.

rr-debugger#6  rr::EmergencyDebugOstream::~EmergencyDebugOstream (this=this@entry=0x7ffe5e4cdf70, __in_chrg=<optimized out>) at rr/src/log.cc:484
rr-debugger#7  0x000056265d0981b7 in rr::Task::did_handle_ptrace_exit_event (this=this@entry=0x56265dde3640) at rr/src/Task.cc:3894
rr-debugger#8  0x000056265cfdb110 in rr::handle_ptrace_exit_event (t=t@entry=0x56265dde3640) at rr/src/RecordSession.cc:279
rr-debugger#9  0x000056265cfe272b in rr::RecordSession::record_step (this=0x56265ddd2f40) at rr/src/RecordSession.cc:2535
rr-debugger#10 0x000056265cfd6674 in rr::record (flags=..., args=...) at rr/src/RecordCommand.cc:697
rr-debugger#11 rr::RecordCommand::run (this=0x56265d1f5a40 <rr::RecordCommand::singleton>, args=...) at rr/src/RecordCommand.cc:860
rr-debugger#12 0x000056265cf3601f in main (argc=<optimized out>, argv=<optimized out>) at rr/src/main.cc:278
bernhardu added a commit to bernhardu/rr that referenced this pull request Apr 22, 2023
@bernhardu
Avoid assert which is now more likely after recent commit.
ca88d20 
Related: 7ffb7d6
See issue 3504.

$ bin/rr record -n bin/pid_ns_kill_child

Error message:
  [FATAL src/Task.cc:2167:did_waitpid() errno: EDOM]
   (task 285229 (rec:285229) at time 269)
   -> Assertion `!handled_ptrace_exit_event' failed to hold.

rr-debugger#6  rr::EmergencyDebugOstream::~EmergencyDebugOstream (this=this@entry=0x7fffb7babb70, __in_chrg=<optimized out>) at rr/src/log.cc:484
rr-debugger#7  0x000056012f0b167d in rr::Task::did_waitpid (this=this@entry=0x56012f9d4640, status=...) at rr/src/Task.cc:2167
rr-debugger#8  0x000056012f086ac7 in rr::Scheduler::reschedule (this=this@entry=0x56012f9c4188, switchable=<optimized out>) at rr/src/Scheduler.cc:882
rr-debugger#9  0x000056012eff4607 in rr::RecordSession::record_step (this=0x56012f9c3f40) at rr/src/RecordSession.cc:2497
rr-debugger#10 0x000056012efe8664 in rr::record (flags=..., args=...) at rr/src/RecordCommand.cc:697
rr-debugger#11 rr::RecordCommand::run (this=0x56012f207a40 <rr::RecordCommand::singleton>, args=...) at rr/src/RecordCommand.cc:860
rr-debugger#12 0x000056012ef4800f in main (argc=<optimized out>, argv=<optimized out>) at rr/src/main.cc:278

With change in Task.cc:
Error message:
  [FATAL src/Task.cc:3894:did_handle_ptrace_exit_event()]
   (task 308641 (rec:308641) at time 269)
   -> Assertion `!handled_ptrace_exit_event' failed to hold.

rr-debugger#6  rr::EmergencyDebugOstream::~EmergencyDebugOstream (this=this@entry=0x7ffe5e4cdf70, __in_chrg=<optimized out>) at rr/src/log.cc:484
rr-debugger#7  0x000056265d0981b7 in rr::Task::did_handle_ptrace_exit_event (this=this@entry=0x56265dde3640) at rr/src/Task.cc:3894
rr-debugger#8  0x000056265cfdb110 in rr::handle_ptrace_exit_event (t=t@entry=0x56265dde3640) at rr/src/RecordSession.cc:279
rr-debugger#9  0x000056265cfe272b in rr::RecordSession::record_step (this=0x56265ddd2f40) at rr/src/RecordSession.cc:2535
rr-debugger#10 0x000056265cfd6674 in rr::record (flags=..., args=...) at rr/src/RecordCommand.cc:697
rr-debugger#11 rr::RecordCommand::run (this=0x56265d1f5a40 <rr::RecordCommand::singleton>, args=...) at rr/src/RecordCommand.cc:860
rr-debugger#12 0x000056265cf3601f in main (argc=<optimized out>, argv=<optimized out>) at rr/src/main.cc:278
bernhardu added a commit to bernhardu/rr that referenced this pull request Apr 25, 2023
@bernhardu
Avoid assert which is now more likely after recent commit.
0c622d1 
Related: 7ffb7d6
See issue 3504.

$ bin/rr record -n bin/pid_ns_kill_child

Error message:
  [FATAL src/Task.cc:2167:did_waitpid() errno: EDOM]
   (task 285229 (rec:285229) at time 269)
   -> Assertion `!handled_ptrace_exit_event' failed to hold.

rr-debugger#6  rr::EmergencyDebugOstream::~EmergencyDebugOstream (this=this@entry=0x7fffb7babb70, __in_chrg=<optimized out>) at rr/src/log.cc:484
rr-debugger#7  0x000056012f0b167d in rr::Task::did_waitpid (this=this@entry=0x56012f9d4640, status=...) at rr/src/Task.cc:2167
rr-debugger#8  0x000056012f086ac7 in rr::Scheduler::reschedule (this=this@entry=0x56012f9c4188, switchable=<optimized out>) at rr/src/Scheduler.cc:882
rr-debugger#9  0x000056012eff4607 in rr::RecordSession::record_step (this=0x56012f9c3f40) at rr/src/RecordSession.cc:2497
rr-debugger#10 0x000056012efe8664 in rr::record (flags=..., args=...) at rr/src/RecordCommand.cc:697
rr-debugger#11 rr::RecordCommand::run (this=0x56012f207a40 <rr::RecordCommand::singleton>, args=...) at rr/src/RecordCommand.cc:860
rr-debugger#12 0x000056012ef4800f in main (argc=<optimized out>, argv=<optimized out>) at rr/src/main.cc:278

With change in Task.cc:
Error message:
  [FATAL src/Task.cc:3894:did_handle_ptrace_exit_event()]
   (task 308641 (rec:308641) at time 269)
   -> Assertion `!handled_ptrace_exit_event' failed to hold.

rr-debugger#6  rr::EmergencyDebugOstream::~EmergencyDebugOstream (this=this@entry=0x7ffe5e4cdf70, __in_chrg=<optimized out>) at rr/src/log.cc:484
rr-debugger#7  0x000056265d0981b7 in rr::Task::did_handle_ptrace_exit_event (this=this@entry=0x56265dde3640) at rr/src/Task.cc:3894
rr-debugger#8  0x000056265cfdb110 in rr::handle_ptrace_exit_event (t=t@entry=0x56265dde3640) at rr/src/RecordSession.cc:279
rr-debugger#9  0x000056265cfe272b in rr::RecordSession::record_step (this=0x56265ddd2f40) at rr/src/RecordSession.cc:2535
rr-debugger#10 0x000056265cfd6674 in rr::record (flags=..., args=...) at rr/src/RecordCommand.cc:697
rr-debugger#11 rr::RecordCommand::run (this=0x56265d1f5a40 <rr::RecordCommand::singleton>, args=...) at rr/src/RecordCommand.cc:860
rr-debugger#12 0x000056265cf3601f in main (argc=<optimized out>, argv=<optimized out>) at rr/src/main.cc:278
bernhardu added a commit to bernhardu/rr that referenced this pull request Jul 10, 2023
@bernhardu
Avoid assert which is now more likely after recent commit.
94e59e3 
Related: 7ffb7d6
See issue 3504.

$ bin/rr record -n bin/pid_ns_kill_child

Error message:
  [FATAL src/Task.cc:2167:did_waitpid() errno: EDOM]
   (task 285229 (rec:285229) at time 269)
   -> Assertion `!handled_ptrace_exit_event' failed to hold.

rr-debugger#6  rr::EmergencyDebugOstream::~EmergencyDebugOstream (this=this@entry=0x7fffb7babb70, __in_chrg=<optimized out>) at rr/src/log.cc:484
rr-debugger#7  0x000056012f0b167d in rr::Task::did_waitpid (this=this@entry=0x56012f9d4640, status=...) at rr/src/Task.cc:2167
rr-debugger#8  0x000056012f086ac7 in rr::Scheduler::reschedule (this=this@entry=0x56012f9c4188, switchable=<optimized out>) at rr/src/Scheduler.cc:882
rr-debugger#9  0x000056012eff4607 in rr::RecordSession::record_step (this=0x56012f9c3f40) at rr/src/RecordSession.cc:2497
rr-debugger#10 0x000056012efe8664 in rr::record (flags=..., args=...) at rr/src/RecordCommand.cc:697
rr-debugger#11 rr::RecordCommand::run (this=0x56012f207a40 <rr::RecordCommand::singleton>, args=...) at rr/src/RecordCommand.cc:860
rr-debugger#12 0x000056012ef4800f in main (argc=<optimized out>, argv=<optimized out>) at rr/src/main.cc:278

With change in Task.cc:
Error message:
  [FATAL src/Task.cc:3894:did_handle_ptrace_exit_event()]
   (task 308641 (rec:308641) at time 269)
   -> Assertion `!handled_ptrace_exit_event' failed to hold.

rr-debugger#6  rr::EmergencyDebugOstream::~EmergencyDebugOstream (this=this@entry=0x7ffe5e4cdf70, __in_chrg=<optimized out>) at rr/src/log.cc:484
rr-debugger#7  0x000056265d0981b7 in rr::Task::did_handle_ptrace_exit_event (this=this@entry=0x56265dde3640) at rr/src/Task.cc:3894
rr-debugger#8  0x000056265cfdb110 in rr::handle_ptrace_exit_event (t=t@entry=0x56265dde3640) at rr/src/RecordSession.cc:279
rr-debugger#9  0x000056265cfe272b in rr::RecordSession::record_step (this=0x56265ddd2f40) at rr/src/RecordSession.cc:2535
rr-debugger#10 0x000056265cfd6674 in rr::record (flags=..., args=...) at rr/src/RecordCommand.cc:697
rr-debugger#11 rr::RecordCommand::run (this=0x56265d1f5a40 <rr::RecordCommand::singleton>, args=...) at rr/src/RecordCommand.cc:860
rr-debugger#12 0x000056265cf3601f in main (argc=<optimized out>, argv=<optimized out>) at rr/src/main.cc:278
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joneschrisg @andreasgal