Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix detecting DHI_NVR as doorbell #242

Merged
merged 2 commits into from
May 28, 2023
Merged

Fix detecting DHI_NVR as doorbell #242

merged 2 commits into from
May 28, 2023

Conversation

goblinmaks
Copy link
Contributor

Fix detection DHI_NVR as doorbell
#241

@goblinmaks
Update __init__.py
99f9a49 
Fix detection DHI_NVR as doorbell
@goblinmaks
Copy link
Contributor Author

@rroller thanks

@tomlut
Copy link

tomlut commented Dec 11, 2022

I assume this would also fix #168 ?

@goblinmaks
Copy link
Contributor Author

goblinmaks commented Dec 14, 2022 •
edited
Loading

@tomlut yes, it should fix #168 also, but to confirm it could you create screenshot of model name as I have attached to #241.
Thanks,

@tomlut
Copy link

tomlut commented Dec 15, 2022

One of my 6 cameras (all connect to the same NVR):

Screenshot 2022-12-15 at 14-24-19 Settings – Home Assistant

@goblinmaks
Copy link
Contributor Author

@rroller could you please review this PR.

@rroller
Copy link
Owner

rroller commented Feb 22, 2023

@rroller could you please review this PR.

Will try to get to this very soon

@goblinmaks
Copy link
Contributor Author

@rroller any update here ?

@rroller
Copy link
Owner

rroller commented May 28, 2023

Thanks for this! Merging!

@rroller rroller merged commit e3d39d9 into rroller:main May 28, 2023
@rroller
Copy link
Owner

rroller commented May 28, 2023

Released in 0.9.45 - https://github.com/rroller/dahua/releases/tag/0.9.45

@rroller rroller mentioned this pull request Jun 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rroller rroller rroller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goblinmaks @tomlut @rroller