Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mix do credo, <anything> does only run credo #41

Closed
NobbZ opened this issue Feb 15, 2016 · 1 comment · Fixed by #42
Closed

mix do credo, <anything> does only run credo #41

NobbZ opened this issue Feb 15, 2016 · 1 comment · Fixed by #42

Comments

@NobbZ
Copy link
Contributor

NobbZ commented Feb 15, 2016

When using mix do only the items up to and including credo are run.

eg:

$ mix do credo, dialyzer
Checking 1 source file ...

Please report incorrect results: https://github.com/rrrene/credo/issues

Analysis took 0.1 seconds (0.00s to load, 0.1s running checks)
7 mods/funs, found no issues.

Showing priority issues: ↑ ↗ →  (use `--strict` to show all issues, `--help` for options).

while

$ mix do dialyzer, credo
Starting Dialyzer
dialyzer --no_check_plt --plt /home/nobbz/.dialyxir_core_18_1.2.0.plt -Wunmatched_returns -Werror_handling -Wrace_conditions -Wunderspecs /home/nobbz/projects/elixir/foo/_build/dev/lib/foo/ebin
  Proceeding with analysis... done in 0m1.25s
done (passed successfully)

Checking 1 source file ...

Please report incorrect results: https://github.com/rrrene/credo/issues

Analysis took 0.1 seconds (0.00s to load, 0.1s running checks)
7 mods/funs, found no issues.
rrrene added a commit that referenced this issue Feb 15, 2016
This was brought up in #41
@rrrene
Copy link
Owner

rrrene commented Feb 15, 2016

Unfortunately, this behaviour is by design:

|> System.halt

Credo exits/fails to provide an exit status, which in turn describes what checks failed during the analysis. I updated the README to include this (it was just listed in the CHANGELOG, my fault 😞)

If you have any suggestions how we could integrate this into mix do while retaining consistent behaviour for Credo, I'm open for ideas 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants