Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrectly identifies -1 as an operator requiring space #43

Closed
hassox opened this issue Feb 17, 2016 · 5 comments
Closed

Incorrectly identifies -1 as an operator requiring space #43

hassox opened this issue Feb 17, 2016 · 5 comments
Assignees
@rrrene

Comments

@hassox
Copy link

hassox commented Feb 17, 2016

I have the following in one of my modules

@max -1

This incorrectly identifies an issue of:

┃ [C] ↗ There are spaces around operators most of the time, but not here.
┃       lib/guardian/permissions.ex:125:7 (Guardian.Permissions)
rrrene added a commit that referenced this issue Feb 17, 2016
@rrrene
Add failing test reproducing #43
dcab901
@rrrene
Copy link
Owner

rrrene commented Feb 17, 2016

@hassox Thx for reporting! I added a (failing) test to reproduce this issue. Will fix as soon as I can!

@hassox
Copy link
Author

hassox commented Feb 17, 2016

thankyou!

@rrrene rrrene self-assigned this Feb 17, 2016
@rrrene
Copy link
Owner

rrrene commented Feb 17, 2016

v0.3.3 contains a fix. 👍

@rrrene rrrene closed this as completed Feb 17, 2016
rrrene added a commit that referenced this issue Feb 17, 2016
@rrrene
Fix false positive for SpaceAroundOperators
17bac8e 
Fixes #43
@hassox
Copy link
Author

hassox commented Feb 17, 2016

speedy! thankyou

@dylan-chong
Copy link
Contributor

Credo 0.8.8 seems to have this bug as well

assert -3 == -3 yields ┃ [C] ↗ There are spaces around operators most of the time, but not here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrrene rrrene

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hassox @rrrene @dylan-chong