Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.credo.exs] Support excluding _build in umbrella e.g. "apps/myapp/_build" #44

Closed
seantanly opened this issue Feb 19, 2016 · 4 comments
Closed
Assignees

Comments

@seantanly
Copy link

Tried setting excluded in .credo.exs with **/_build/ but it didn't work. _build folders in apps/ folders are still being evaluated.

%{
  configs: [
    %{
      name: "default",
      files: %{
        included: ["lib/", "src/", "web/", "apps/"],
        excluded: ["**/_build/"]
      },
...
@rrrene rrrene self-assigned this Feb 19, 2016
@dpehrson
Copy link

Just hit this as well, it also seems to be doing apps/*/deps.

Strangely I have credo in a project at work that doesn't behave this way and I have no idea why.

rrrene added a commit that referenced this issue Apr 24, 2016
@rrrene rrrene added this to the Release v0.4.0 milestone May 8, 2016
@rrrene
Copy link
Owner

rrrene commented May 19, 2016

This was released as part of v0.4.0-beta1. Please report any further issues you might find.

@rrrene rrrene closed this as completed May 19, 2016
@seantanly
Copy link
Author

seantanly commented May 22, 2016

@rrrene thanks, going with v0.4.0-beta1 and changing the excluded configuration as suggested by the commit above fixes the issue.

@dpehrson The following updated config works correctly now. :)

%{
  configs: [
    %{
      name: "default",
      files: %{
        included: ["lib/", "src/", "web/", "apps/"],
        excluded: [~r"/_build/", ~r"/deps/"]
      },
...

@rrrene
Copy link
Owner

rrrene commented May 22, 2016

@seantanly @dpehrson Just to be clear, you don't have to change your config with v0.4.0-beta1 since the snippet you provided is now part of the default config 💛 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants