"Space around operators most of the time, but not here." Issue

[hackling]

┃    __ CODE IN QUESTION
┃
┃       |> Date.shift(days: n * -1)
┃                               ^
┃
┃    __ WHY IT MATTERS
┃
┃       Don't use spaces after operators like `+`, `-`, `*` and `/`. This is the
┃       **preferred** way, although other styles are possible, as long as it is
┃       applied consistently.

I do prefer space around my operators, but I do also like to have negative numbers. -20 * -13 also seems acceptable to me as well. Thoughts?

[hackling]

┃    __ CODE IN QUESTION
┃
┃       fn(field)->
┃                ^^
┃
┃    __ WHY IT MATTERS
┃
┃       Don't use spaces after operators like `+`, `-`, `*` and `/`. This is the
┃       **preferred** way, although other styles are possible, as long as it is
┃       applied consistently.

Worth noting the false positive I got here....

[rrrene]

Hi Nicholas,

your first example is clearly a bug in Credo. In the second example, the help text is wrong 😞 my bad!

Will investigate and fix soon!

[rrrene]

And thx for reporting! 👍

[rrrene]

v0.3.6 contains a patch for this! Thx for reporting 👍

[c-rack]

@rrrene I have a similar false positive for this line (a simple input to integer function):
https://github.com/c-rack/cidr-elixir/blob/master/lib/cidr.ex#L196

Just checked with 0.3.6, but the "There are spaces around operators most of the time, but not here" message still appears for this line. Shall I open another issue or want you re-open this one?

[rrrene]

@Crack Please check with cough v0.3.7. 😁

[c-rack]

Works like a charm, thanks 👍

[dylan-chong]

Is the first issue mentioned supposed to be fixed?

I can still get that issue using IO.inspect -3 and assert -3 == -3

┃ [C] ↗ There are spaces around operators most of the time, but not here.

[jessejanderson]

I'm getting this error for a test where I want to assert a negative result. I'm using 0.9.0-rc1.

assert -12 == MyApp.fun_that_should_return_a_negative

[dylan-chong]

@rrrene I just want to check that you are getting these messages.

[rrrene]

@dylan-chong 👍

[rrrene]

This has been fixed for Elixir version >= 1.6.0-rc. 👍