Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish well-formulated and concise types #1487

Open
1 task done
tmc opened this issue May 29, 2024 · 1 comment
Open
1 task done

publish well-formulated and concise types #1487

tmc opened this issue May 29, 2024 · 1 comment
Labels
feature request Things want to be added

Comments

@tmc
Copy link

tmc commented May 29, 2024

Preflight Checklist

  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

What package is this feature request for?

rrweb

Problem Description

Today the types that define the payloads the rrweb ecosystem operates over are a bit spread out which makes them not super accessible to other language environments.

Proposed Solution

Tidy up and publish a small set of straightforward types.

Alternatives Considered

Not doing so.

Additional Information

No response

@tmc tmc added the feature request Things want to be added label May 29, 2024
@eoghanmurray
Copy link
Contributor

eoghanmurray commented Jun 18, 2024

types that are used in both packages/rrweb and packages/rrweb-snapshot end up in packages/types/src/index.ts

the recording payload types should mostly be in packages/rrweb/src/types.ts
looks like the recording types are now mostly in packages/types/src/index.ts also for importing to packages/rrdom or rrvideo

can you elaborate on which ones you are looking for and where you expected them to be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Things want to be added
Projects
None yet
Development

No branches or pull requests

2 participants