lastPlayedEvent not populated w FullSnapshot on 'fullsnapshot-rebuilded' event

[eoghanmurray]

	rrweb_replayer.on('fullsnapshot-rebuilded', function() {
            if (rrweb_replayer.lastPlayedEvent.type == rrweb.EventType.FullSnapshot) {
                 console.log('expected');
            } else if (rrweb_replayer.lastPlayedEvent.type == rrweb.EventType.Meta) {
                 console.error('unexpected');
            }
        }

The output is unexpected.

I've actually already written code which relys on the Meta event (in order to know the current URL and update the UI), but I've now run into a case where I need to look at the DOM produced.

Should we:

• have separate events for the Meta & FullSnapshot ('new-page-load', 'new-page-rendered')?
• pass in the event itself to the callback function?

[Yuyz0112]

I've passed the event to the callback function.

There is also a general event-cast event, which will emit when event cast and has the event as its payload. Looks like a solution to handle meta event without providing more event types.

[eoghanmurray]

Cool, should we deprecate the fullsnapshot-rebuilded event?

The correct English is 'rebuilt' so maybe we could create a new event for the FullSnapshot called fullsnapshot-rebuilt (which gets called correctly after the rebuilding is done).