Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not move backward in the player #277

Closed
raminious opened this issue Aug 2, 2020 · 6 comments
Closed

Can not move backward in the player #277

raminious opened this issue Aug 2, 2020 · 6 comments

Comments

@raminious
Copy link

raminious commented Aug 2, 2020

Hello,
I'm trying to implement two basic functionalities that jump forward and backward in the player. jumping forward is working as expected but jumping backward doesn't working. I spent a couple of hours to debug with no success.

I provided a basic Codesandbox if you want to take a look at that

https://codesandbox.io/s/sharp-chatterjee-dyesu?file=/src/index.js
https://dyesu.csb.app/

Steps to reproduces:
on the above example,

1- click on play button
2- click on move forward button
3- click on move backward button (it doesn't work)

I see it's working in the rrweb-player (seeking time progress) component, so I really curious to know what's wrong with my implementation

thank you so much

@Juice10
Copy link
Contributor

Juice10 commented Aug 3, 2020

I believe #264 fixes this

@raminious
Copy link
Author

@Juice10 I do confirm.

@raminious
Copy link
Author

raminious commented Aug 3, 2020

@Juice10 I was testing another replay on your branch (replay-seeking) and got error when I was trying to seek forward the video.

deepRemoveFromMirror(((childNode as unknown) as INode).__sn.id),

I thought it might be interesting for you to investigate that

https://streamable.com/zhsezc

image

image

@Juice10
Copy link
Contributor

Juice10 commented Aug 4, 2020

@raminious I think that might have to do with #98, would you mind sharing the events that where generated for this recording?

@raminious
Copy link
Author

raminious commented Aug 5, 2020

@Yuyz0112
Copy link
Member

Yuyz0112 commented Aug 9, 2020

#274 has been merged with a fix of this. And the rrweb-player will use the latest rrweb when rrweb-io/rrweb-player#26 this PR is merged.

@Yuyz0112 Yuyz0112 closed this as completed Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants