Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<select> value is not masked when maskInputOptions is turned on #746

Closed
lee-userback opened this issue Nov 3, 2021 · 0 comments
Closed
Labels
fixed Issue has been fixed

Comments

@lee-userback
Copy link

lee-userback commented Nov 3, 2021

RRWEB Settings:

rrwebRecord({
    maskInputOptions: {
        select: true
    }
})

HTML:

<select>
    <option selected>Item 1</option>
    <option>Item 2</option>
</select>

Bug:
When the <select> is loaded with a default selected value, the default value "Item 1" is still displayed without any masking. When I change the option to "Item 2", "Item 2" shows as blank in the replay. So it looks like there is some masking going on when the select value is changed, but the default value does not have any masking.

Expected behaviour:
The select element should show "********" instead of "Item 1".

Yuyz0112 pushed a commit that referenced this issue Jan 26, 2022
… to fix issue #746 (#810)

* feat: add observer for 'selected' setter of HTMLOptionElement and try to fix issue #746

* style: add description of mechanism
@YunFeng0817 YunFeng0817 added the fixed Issue has been fixed label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Issue has been fixed
Projects
None yet
Development

No branches or pull requests

2 participants