feat: add observer for 'selected' setter of HTMLOptionElement and try to fix issue #746 #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuyz0112
reviewed
Jan 25, 2022
| const userTriggered = event.isTrusted; | ||
| if (target && (target as Element).tagName === 'OPTION') | ||
| target = (target as Element).parentElement; |
There was a problem hiding this comment.
please inline the mechanism as comment at here
BTW, is there any doc/spec pointing out the parent element of option should be select?
There was a problem hiding this comment.
No problem, I will add it.
is there any doc/spec pointing out the parent element of option should be select
This is a good point, parent element could also be <optgroup> and <datalist> according to
captured from OptionElement MDN.
But these two elements aren't hooked for now, so this exception could be excluded by this conditionINPUT_TAGS.indexOf((target as Element).tagName) < 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we change the 'selected' value of an option element, the value of its parent select element would be changed as well. So I add an observer for the 'selected' setter.