RSA keygen in preparation to asking /id from ipfs #95

koivunej · 2020-03-12T10:19:05Z

Sorry for the refactoring with the http being here as well, I created a config module with configuration file handling there. The rsa keygen and following import/export thing was a lot more difficult than I thought.

I made some questionable changes to ipfs::config as well, I removed it from the ifps::IpfsOptions. I made this because looking back at the ipfs::config::KeyMaterial it seems like a bad idea to extend it with Pkcs8Buffer or something similar, I am not so sure if the mutability through Options makes a lot of sense. If this solution feels worse I can present the KeyMaterial extension as well. I also thought that the "library initialization through configuration file" might not be so important use case after all, as most likely you'd like to bring your application configuration file and turn that into the ipfs::IpfsOptions.

This could be mergeable as is. I'll continue from here into spawning the background task and exposing the ipfs::Ipfs to the filters, but hopefully on a different PR.

in preparation for making the library outside configurable without a configuration file.

this should hopefully lead to ConfigFile not being needed anymore

taking on the openssl dependency is used for: - rsa key generation - from/to `pkcs#1` and `pkcs#8` transformations Crate `rsa` was also considered but it does not support exporting keys in any format at the moment and it's import code looks different from `ring`s (this could be the case of not importing the "precomputed" values in `rsa`). The `pkcs#1` is (hopefully) used with go-ipfs-config/go-libp2p compatible key storage but rust-libp2p/ring need the key in `pkcs#8` der format. PEM parsing and PEM to DER was implemented by hand as it looked like the existingly depended on crates are not compatible as much as possible.

this might need to be changed silently to 2048 if the tests use 1024 bit keys.

copied openssl vcpkg magic from https://github.com/actix/actix-web/blob/53ff3ad0998ccbe9fdbf2398ca32b795149254fa/.github/workflows/windows.yml

dvc94ch

Looks very good, thanks!

dvc94ch · 2020-03-12T12:01:46Z

http/src/main.rs

+                    // strings from go-ipfs
+                    eprintln!("Error: ipfs configuration file already exists!");
+                    eprintln!("Reinitializing would override your keys.");
+                    std::process::exit(1);


are the go ipfs error messages checked in the compliance test suite?

I don't think so but I tried to include the ones I found. These might be presented in the conformance test assertion failures, at least if it happens during preparation.

dvc94ch · 2020-03-12T12:03:44Z

Is there no other way to do it except using openssl?

koivunej · 2020-03-12T12:18:32Z

Sadly I cannot see a way. rsa crate exists and would be suitable for our testing purposes at least (there are warnings for not having audited) but for testing purposes I'd be happy to get any key from rsa imported as ring key used by rust-libp2p. There isn't any export PKCS#{1,8} functionality in rsa I could find (even less import/export in released version, some import features have been added later) but even the latest importing seems to differ from how ring imports RSA keys. As DER functionality is not exposed by openssl either so I had to hack it, luckily it's the easiest thing done here (see pem_to_der).

I wrote more/different notes on aae24e1.

The windows github actions openssl should be doable, but I can't see what would the solution be. Trying to ask around.

koivunej · 2020-03-12T12:24:39Z

@dvc94ch asking to make sure you saw the ipfs::config::ConfigFile related changes in ipfs::IpfsOptions I mentioned in PR description while I research the openssl library installation:

I made some questionable changes to ipfs::config as well, I removed it from the ifps::IpfsOptions. I made this because looking back at the ipfs::config::KeyMaterial it seems like a bad idea to extend it with Pkcs8Buffer or something similar, I am not so sure if the mutability through Options makes a lot of sense.

src/lib.rs

dvc94ch · 2020-03-12T12:42:25Z

I agree that it makes sense to make the configuration the responsibility of the user, in this case http

koivunej · 2020-03-12T12:51:48Z

Is there no other way to do it except using openssl?

Sadly I cannot see a way.

To elaborate on others than the rsa:

rustls: couldn't find key generation or export
ring: couldn't find key generation (but help to use openssl), not sure on exporting

I agree that it makes sense to make the configuration the responsibility of the user, in this case http

Great! Thanks for the another look.

Still no luck with the build however, there are some open issues like sfackler/rust-openssl#1062 but strange not to find examples on this.

apparently these images have the openssl installed on some hosts.

this is because I don't know how to install openssl in a cross compilable way with brew/apt-get.

koivunej · 2020-03-12T13:57:31Z

Trying to disable http on cross builds as I have no idea on how to start building openssl or downloading any prebuilts for the cross compilation with either apt or brew. I'll create an issue for this, I'm sure someone knows how to fix this.

In addition to typoing the http crate name again I managed to remove cross compilation on the non-android cross compilation targets.

Joonas Koivunen added 7 commits March 12, 2020 12:12

refactor: move v0::version in own module

a344c7c

add: re-export multiaddr, peerid, keypair

fecee69

in preparation for making the library outside configurable without a configuration file.

refactor: move bootstrap and secio_key_pair to IpfsOptions

8c2705b

this should hopefully lead to ConfigFile not being needed anymore

fix: use base64pad instead of base64, field names

7499141

fix: output the generated peerid in main

ad771f5

chore: refresh lockfile

5577b63

koivunej requested a review from dvc94ch March 12, 2020 10:19

koivunej changed the title ~~Actual~~ RSA keygen in preparation to asking /id from ipfs Mar 12, 2020

chore: cargo fmt

274b2e5

koivunej force-pushed the actual_id branch from 7151efd to 274b2e5 Compare March 12, 2020 10:22

Joonas Koivunen added 6 commits March 12, 2020 12:26

fix: warning on unused variable

7c60ec9

doc: add doc comments for config

5c58335

fix: deny init with <= 2048 bit keys

87f9077

this might need to be changed silently to 2048 if the tests use 1024 bit keys.

add: tests for pem_to_der

7a1d3c6

add: test for loading go-ipfs 0.4.23 rsa key

fbabbfd

fix: try fixing ci on windows

0898d0d

copied openssl vcpkg magic from https://github.com/actix/actix-web/blob/53ff3ad0998ccbe9fdbf2398ca32b795149254fa/.github/workflows/windows.yml

dvc94ch approved these changes Mar 12, 2020

View reviewed changes

koivunej mentioned this pull request Mar 12, 2020

IPFS_PATH Folder Compatibility #88

Closed

dvc94ch reviewed Mar 12, 2020

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

dvc94ch reviewed Mar 12, 2020

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

Joonas Koivunen added 4 commits March 12, 2020 14:54

fix: try setting VCPKGRS_DYNAMIC for windows build

1e435c2

fix: try fix android, mac with explicit deps

b13d11e

apparently these images have the openssl installed on some hosts.

fix: try with correct libssl-dev package name

b2af111

fix: try disabling http on cross compilation targets

e1d08f3

this is because I don't know how to install openssl in a cross compilable way with brew/apt-get.

Joonas Koivunen added 3 commits March 12, 2020 16:02

chore: move use std::fmt with others

22e2423

refactor: borrowing getters in IpfsOptions

9ce86f1

fix: try fix build by fixing excludes, restore cross

9354655

In addition to typoing the http crate name again I managed to remove cross compilation on the non-android cross compilation targets.

koivunej merged commit e5c7c08 into rs-ipfs:master Mar 12, 2020

This was referenced Mar 12, 2020

Partial builds on CI cross targets #96

Open

Swarm http #99

Merged

koivunej deleted the actual_id branch March 16, 2020 11:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RSA keygen in preparation to asking /id from ipfs #95

RSA keygen in preparation to asking /id from ipfs #95

koivunej commented Mar 12, 2020

dvc94ch left a comment

dvc94ch Mar 12, 2020

koivunej Mar 12, 2020 •

edited

Loading

dvc94ch commented Mar 12, 2020

koivunej commented Mar 12, 2020

koivunej commented Mar 12, 2020

dvc94ch commented Mar 12, 2020

koivunej commented Mar 12, 2020

koivunej commented Mar 12, 2020

RSA keygen in preparation to asking /id from ipfs #95

RSA keygen in preparation to asking /id from ipfs #95

Conversation

koivunej commented Mar 12, 2020

dvc94ch left a comment

Choose a reason for hiding this comment

dvc94ch Mar 12, 2020

Choose a reason for hiding this comment

koivunej Mar 12, 2020 • edited Loading

Choose a reason for hiding this comment

dvc94ch commented Mar 12, 2020

koivunej commented Mar 12, 2020

koivunej commented Mar 12, 2020

dvc94ch commented Mar 12, 2020

koivunej commented Mar 12, 2020

koivunej commented Mar 12, 2020

koivunej Mar 12, 2020 •

edited

Loading