Added .read_cif() function and test file test_cif.py #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JBGreisman
requested changes
Jul 11, 2023
JBGreisman
reviewed
Jul 11, 2023
JBGreisman
reviewed
Jul 11, 2023
Updated description of read_cif
added `assert dataset.merged` to `test_read_merged`
JBGreisman
reviewed
Sep 1, 2023
Condensed to 10K reflections
Updated to reflect gemmi version 0.6.2
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## main #217 +/- ##
==========================================
- Coverage 98.39% 92.39% -6.00%
==========================================
Files 45 37 -8
Lines 1803 2434 +631
==========================================
+ Hits 1774 2249 +475
- Misses 29 185 +156
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 18 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JBGreisman
approved these changes
Sep 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
.read_cif()currently works for single-dataset.ciffiles with merged structure factors.