Disk caching of UIWebView resources on iOS 4.2 #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from iOS 4.2, all NSCachedURLResponse coming from an UIWebView have a storagePolicy set to
NSURLCacheStorageAllowedInMemoryOnly
(instead ofNSURLCacheStorageAllowed
in the previous iOS versions).Of course, as SDURLCache honors the storagePolicy, it won't cache any of the UIWebView response to the disk.
In order to fix this, I implemented an option that force SDURLCache to cache requests with
NSURLCacheStorageAllowedInMemoryOnly
. This option is enabled by default when running on iOS >= 4.2 (and disabled otherwise).It may impact performances (as the InMemoryOnly policy is always ignored, even when legitimate). Maybe there is a better way to hook into the UIWebView NSURLConnection or NSURLProtocol to fix this?