Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recalculate ETag after OnUpdate/OnInsert hooks, before storing. Fixes… #257

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Recalculate ETag after OnUpdate/OnInsert hooks, before storing. Fixes… #257

merged 1 commit into from
Aug 21, 2019

Conversation

Dragomir-Ivanov
Copy link
Contributor

… #255

@Dragomir-Ivanov
Copy link
Contributor Author

About documentation...since this behavior sound common sense, do I still need to add some clarification in the README?

@smyrman
Copy link
Collaborator

smyrman commented Aug 20, 2019

Probably it's OK without additional documentation at this stage.

smyrman
smyrman previously approved these changes Aug 20, 2019
View reviewed changes
@smyrman
Copy link
Collaborator

smyrman commented Aug 20, 2019

@Dragomir-Ivanov, do you consider this ready for merge?

@smyrman
Copy link
Collaborator

smyrman commented Aug 20, 2019 •
edited
Loading

If you can, maybe improve the commit message according to these conventions:

Especially the subject line is important (to make history look better). E.g.

Recalculate E-Tag right before before storing items

E-tags used to be set after parsing an item only, before potential hooks
alter the item content. This change adds a final step to resource Update
and Create operations to recalculate E-tags right before passing items
to the Storer back-end.

Fixes #257

Or something like that

@Dragomir-Ivanov
Recalculate E-Tag right before before storing items
8908708 
E-tags used to be set after parsing an item only, before potential hooks
alter the item content. This change adds a final step to resource Update
and Create operations to recalculate E-tags right before passing items
to the Storer back-end.

Fixes rs#255
@Dragomir-Ivanov
Copy link
Contributor Author

Thanks for the suggestion @smyrman. Recommitted with the new message & ready for merge.

@smyrman smyrman merged commit 6cf03b0 into rs:master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smyrman smyrman smyrman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dragomir-Ivanov @smyrman