Deprecate BDS::CommonUsageGICB...

This was incorrectly implemented, since you can't just check the first
two 4 bit values. You check some reserved fields for probability and not
any identifier.

This came with a false positive for this test when it is actually just
known format.

Signed-off-by: wcampbell <wcampbell1995@gmail.com>

src/bds.rs

@@ -13,10 +13,6 @@ pub enum BDS {
     #[deku(id = "0x10")]
     DataLinkCapability(DataLinkCapability),
 
-    /// (1, 7) Table A-2-23
-    #[deku(id = "0x17")]
-    CommonUsageGICBCapabilityReport(CommonUsageGICBCapabilityReport),
-
     /// (2, 0) Table A-2-32
     #[deku(id = "0x20")]
     AircraftIdentification(#[deku(reader = "aircraft_identification_read(deku::rest)")] String),
@@ -38,12 +34,6 @@ impl std::fmt::Display for BDS {
             Self::DataLinkCapability(_) => {
                 writeln!(f, "Comm-B format: BDS1,0 Datalink capabilities")?;
             },
-            Self::CommonUsageGICBCapabilityReport(_) => {
-                writeln!(
-                    f,
-                    "Comm-B format: BDS1,7 Common Usage GICB Capability Report"
-                )?;
-            },
             Self::Unknown(_) => {
                 writeln!(f, "Comm-B format: unknown format")?;
             },
@@ -85,128 +75,3 @@ pub struct DataLinkCapability {
     pub reserved_acas: u8,
     pub bit_array: u16,
 }
-
-/// To indicate common usage GICB services currently supported
-#[derive(Debug, PartialEq, DekuRead, Clone)]
-pub struct CommonUsageGICBCapabilityReport {
-    /// 0,5
-    #[deku(bits = "1")]
-    pub extended_squitter_airborne_position: bool,
-
-    /// 0,6
-    #[deku(bits = "1")]
-    pub extended_squitter_surface_position: bool,
-
-    /// 0,7
-    #[deku(bits = "1")]
-    pub extended_squitter_status: bool,
-
-    /// 0,8
-    #[deku(bits = "1")]
-    pub extended_squitter_identification_and_category: bool,
-
-    /// 0,9
-    #[deku(bits = "1")]
-    pub extended_squitter_airborne_velocity_information: bool,
-
-    /// 0,a
-    #[deku(bits = "1")]
-    pub extended_squitter_event_driven_information: bool,
-
-    /// 2,0
-    #[deku(bits = "1")]
-    pub aircraft_identification: bool,
-
-    /// 2,1
-    #[deku(bits = "1")]
-    pub aircraft_registration_number: bool,
-
-    /// 4,0
-    #[deku(bits = "1")]
-    pub selected_vertical_intention: bool,
-
-    /// 4,1
-    #[deku(bits = "1")]
-    pub next_waypoint_ident: bool,
-
-    /// 4,2
-    #[deku(bits = "1")]
-    pub next_waypoint_position: bool,
-
-    /// 4,3
-    #[deku(bits = "1")]
-    pub next_waypoint_information: bool,
-
-    /// 4,4
-    #[deku(bits = "1")]
-    pub meteorological_routine_report: bool,
-
-    /// 4,5
-    #[deku(bits = "1")]
-    pub meteorological_hazard_report: bool,
-
-    /// 4,8
-    #[deku(bits = "1")]
-    pub vhf_channel_report: bool,
-
-    /// 5,0
-    #[deku(bits = "1")]
-    pub track_and_turn_report: bool,
-
-    /// 5,1
-    #[deku(bits = "1")]
-    pub position_coarse: bool,
-
-    /// 5,2
-    #[deku(bits = "1")]
-    pub position_fine: bool,
-
-    /// 5,3
-    #[deku(bits = "1")]
-    pub air_referenced_state_vector: bool,
-
-    /// 5,4
-    #[deku(bits = "1")]
-    pub waypoint_1: bool,
-
-    /// 5,5
-    #[deku(bits = "1")]
-    pub waypoint_2: bool,
-
-    /// 5,6
-    #[deku(bits = "1")]
-    pub waypoint_3: bool,
-
-    /// 5,f
-    #[deku(bits = "1")]
-    pub quasi_static_parameter_monitoring: bool,
-
-    /// 6,0
-    #[deku(bits = "1")]
-    pub heading_and_speed_report: bool,
-
-    #[deku(bits = "1")]
-    pub reserved_for_aircraft_capability0: bool,
-
-    #[deku(bits = "1")]
-    pub reserved_for_aircraft_capability1: bool,
-
-    /// E,1
-    #[deku(bits = "1")]
-    pub reserved_for_mode_s_bite: bool,
-
-    /// E,2
-    #[deku(bits = "1")]
-    pub reserved_for_mode_s_bit: bool,
-
-    /// F,1
-    #[deku(bits = "1")]
-    pub military_applications: bool,
-
-    /// Reserved0
-    #[deku(bits = "3")]
-    pub reserved0: u8,
-
-    /// Reserved1
-    pub reserved1: [u8; 3],
-}

src/lib.rs

@@ -362,8 +362,6 @@ pub enum DF {
         /// UM: Utility Message
         um: UtilityMessage,
         /// ID: Identity
-        ///
-        /// TODO: does this work?
         #[deku(
             bits = "13",
             endian = "big",

tests/test.rs

@@ -891,3 +891,18 @@ fn test_issue_09() {
         resulting_string
     );
 }
+
+#[test]
+fn test_issue_16() {
+    let bytes = hex!("a227ed3417826515bebd01707629");
+    let frame = Frame::from_bytes((&bytes, 0)).unwrap().1;
+    let resulting_string = format!("{}", frame);
+    assert_eq!(
+        r#" Comm-B, Altitude Reply
+  ICAO Address:  abef98 (Mode S / ADS-B)
+  Altitude:      20300 ft
+  Comm-B format: unknown format
+"#,
+        resulting_string
+    );
+}