Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal left in broken state #116

Closed
dwillmore opened this issue Feb 17, 2022 · 12 comments · Fixed by #124
Closed

Terminal left in broken state #116

dwillmore opened this issue Feb 17, 2022 · 12 comments · Fixed by #124

Comments

@dwillmore
Copy link

After exiting from radar, any mouse action in the text terminal from which it was run now disaplay as excape characters. This persists until the terminal is closed. ESC c did not clear this conditon. Seems radar is not restoring the terminal condition upon exit.

@wcampbell0x2a
Copy link
Member

After exiting from radar, any mouse action in the text terminal from which it was run now disaplay as excape characters. This persists until the terminal is closed. ESC c did not clear this conditon. Seems radar is not restoring the terminal condition upon exit.

What terminal are you using, I'll test this later.

@dwillmore
Copy link
Author

dwillmore commented Feb 17, 2022 via email

@dwillmore
Copy link
Author

I tried it with the Gnome terminal and got similar results.

@wcampbell0x2a
Copy link
Member

I can't reproduce this with gnome-terminal, did you exit radar after a panic or something or were you using q or ctrl+c?

@dwillmore
Copy link
Author

dwillmore commented Feb 18, 2022 via email

@wcampbell0x2a
Copy link
Member

Huh, I've run into what you are talking about randomly. I'll try and reproduce it more..

@dwillmore
Copy link
Author

dwillmore commented Feb 18, 2022 via email

@wcampbell0x2a
Copy link
Member

Can you confirm that this merge request: #124, fixed your issue? Thanks

@dwillmore
Copy link
Author

I can't build here due to the package requiring a newer version of Rust than Fedora 34 provides. I can test a binary, but there's no release with this change in it, yet.

@wcampbell0x2a
Copy link
Member

Sorry about that, I always want to use new features. I usually use rustup so that's not a problem.

That being said, you can grab the latest binaries from the CI build like such: https://github.com/rsadsb/adsb_deku/actions/runs/1913359381

@dwillmore
Copy link
Author

dwillmore commented Mar 1, 2022 via email

@dwillmore
Copy link
Author

I can verify that this fix works. Thank you. I had to rig up rtl_adsb and netcat because 1090 required a newer version of SoapySDR, but that shouldn't invalidate the testing. I reproduced the old failure and the new success just to be sure.

Thank you, again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants