Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiArrangement task data input #78

Merged
merged 22 commits into from
Sep 17, 2020
Merged

Conversation

JasperVanDenBosch
Copy link
Contributor

@JasperVanDenBosch JasperVanDenBosch commented Jul 21, 2020

This aims to enable easy importing of behavioral results from the MA task as recorded on Meadows. For now it would support the .mat file type for this task, and all the scopes (single task / multiple tasks / one participant / multiple participants). More on different file types here. Future work could support other tasks with similarity data, such as the dragrate, triplet and discriminability task.

Here is an example of the interface:

## general interface for all files, but denotes return type is RDMs object (to distinguish from DataSet TBA)
rdms = pyrsa.io.meadows.load_rdms('/path/to/ma_1D.mat')

Features / todo’s

  • detection of scope
  • creating RDMs
  • scope: single task
  • scope: one participant / single task
  • scope: multiple participants / single task
  • add descriptors from subject
  • sphinx auto doc stub
  • sample data files (neurdyn study? Check for PIDs)
  • acceptance test: import sample file and check dataset similarity correspondence

revision

  • (optional flag) sort stimuli alphabetically and reorder RDM accordingly
  • resolves fix RDMs.sort_by() #96
  • Double check fortran/C ordering in MAT files, why is order z-a in test

@JasperVanDenBosch JasperVanDenBosch self-assigned this Jul 21, 2020
@JasperVanDenBosch JasperVanDenBosch marked this pull request as ready for review July 22, 2020 10:50
Copy link
Contributor

@HeikoSchuett HeikoSchuett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to do what it is supposed to do and the tests confirm that it works, so I approve it.

I am not sure how general this is compared to the possible formats you could get from meadows, but I assume you do and it is general enough?

@JasperVanDenBosch
Copy link
Contributor Author

I am not sure how general this is compared to the possible formats you could get from meadows, but I assume you do and it is general enough?

No to be honest this only supports one file type and only data for one type of task. But I figured it might be good to get some feedback on this now and at least have the most commonly used one in here, as the users often ask for code to do this.

@iancharest
Copy link
Contributor

once we have the order of the stimuli (and rows and columns of the RDMs) sorted, so that this is then common across participants, i think i can approve this PR indeed.

@JasperVanDenBosch
Copy link
Contributor Author

@iancharest the rdm is now sorted by default, and I've compared the json and matlab order and they are the same.

@JasperVanDenBosch
Copy link
Contributor Author

@HeikoSchuett So I changed RDMs.sort_by(), what do you think?

Copy link
Contributor

@iancharest iancharest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now looks good. happy for this to be merged.

@JasperVanDenBosch JasperVanDenBosch merged commit 16a6b91 into master Sep 17, 2020
@JasperVanDenBosch JasperVanDenBosch deleted the meadows-ma-dataset-input branch September 17, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix RDMs.sort_by()
3 participants