-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug fixes/typos in the docs for jekyll-web export #75
Conversation
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Ping @NickleDave for review! Sorry for the noise of isort, but this PR should:
|
To test I cloned, checked out the PR, and installed into the .venv for my bioacoustics-software feature branch.
✔️ for the second case in #73 the error is now correctly formatted so I can see what the missing field is:
This is confusing though, because I do have a column "Title" that is copied directly from the example spreadsheet so I know it's formatted the same way
|
@NickleDave some comments! For this one:
I'll instead write the response.reason (push coming soon for you to test again!) And this one:
The first row of the sheet seems to be a comment: Did you add this / not use the template? In the above, the title is in the second row. My example looks like this:
Yes exactly! Instead of moving forward without the error and raising an exception, it shows exactly how the command is typically used.I'm going to add another newline so it's separate from the first part. |
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Here is the example template sheet, if you don't have it handy. https://docs.google.com/spreadsheets/d/1ZW2kOsBOfSpRSH_9Efvz-ytn7dQ2m1DmYDBdIVNGY4c/edit#gid=0 |
The first row is somehow hidden in the copy I made of Tessa's spreadsheet? I didn't even know you could do that in Google Sheets. This is yet another reason why spreadsheets are the devil
Sorry if it wasn't clear -- I already tested on the template. Works great 👌
I tested and there's a space here now. Why not raise an error? |
Huh, I'm not sure why it's hanging - I do a sys.exit, see https://github.com/rseng/rse/pull/75/files#diff-d322afafceee4094f785edb1cd91db3ec9edc923aec9d76af34ec326bc6edfd9R67. |
Did you press enter after (and perhaps it did exit and the terminal just needs to catch up?) |
No, I'm pretty sure it's just hanging |
This is what I get when I Ctrl+C to break out of it, in case it helps:
|
Testing again now! Hopefully I can reproduce and fix this up! |
okay reproduced! Will push a fix shortly. |
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
okay should be fixed! d440401 |
Confirmed that this exits as expected now
|
yay! Okay to merge and release then? |
is your computer named pimienta? That's super cute! 🌶️ |
LGTM! 👍
yes. long story 😛 |
I hope I can hear it someday! 😆 |
This will address:
rse import
#73rse import
#74 (somewhat)rse export
but still got "Export is complete!" #72Signed-off-by: vsoch vsoch@users.noreply.github.com