DAISIE_format_IW fails when island empty

[Neves-P]

If ran:

set.seed(1)
DAISIE::DAISIE_sim(
  time = 10,
  M = 1000,
  pars = c(1.0e+00, 4.0e-01, 1.5e+01, 1.0e-04, 2.0e-01),
  replicates = 100,
  divdepmodel = "IW"
)

on any branch develop or above format IW fails due to btimes being empty.

[Neves-P]

I will try to get this working in the next couple of days, @joshwlambert, @xieshu95, have you done some changes in the format IW code? If so, that's absolutely fine, it's really how it goes, don't worry! 😄 If you have, could you point me in the broad direction of what you changed?

[Neves-P]

This:

DAISIE/R/DAISIE_format_IW.R

Line 31 in 863d143

# island_list[[2]] = list(branching_times = totaltime, stac = 0, missing_species = 0)

was the offending line. Any idea why this was added, @xieshu95, @joshwlambert, @rsetienne, @richelbilderbeek. It's totally fine, but I fear that by "fixing" it I broke something of yours!

[richelbilderbeek]

Some people have a rule: 'If it can be removed without breaking tests, it should be removed'. Or the Beyonce principle: 'If you like it, then you gotta [sic] put a test on it'.

So, well done 👍

[joshwlambert]

I don't recognise the line, so shouldn’t affect my stuff. Thanks for fixing.

…

On Tue, 30 Jul 2019 at 19:58, Pedro Neves ***@***.***> wrote: This: https://github.com/rsetienne/DAISIE/blob/863d143d5b5a6555ee2ea5c1a9d6fb18323d57e0/R/DAISIE_format_IW.R#L31 was the offending line. Any idea why this was added, @xieshu95 <https://github.com/xieshu95>, @joshwlambert <https://github.com/joshwlambert>, @rsetienne <https://github.com/rsetienne>, @richelbilderbeek <https://github.com/richelbilderbeek>. It's totally fine, but I fear that by "fixing" it I broke something of yours! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#21?email_source=notifications&email_token=ALDSQQXBG53XDVCIBOLQ4STQCB6LPA5CNFSM4IGFMPH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3EZFEA#issuecomment-516526736>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALDSQQRR2EORYYV7GCPIXU3QCB6LPANCNFSM4IGFMPHQ> .

[Neves-P]

Thanks, both! 😄