forked from bitcoinj/bitcoinj
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed duplicated classes from bitcoin package #15
Open
rmoreliovlabs
wants to merge
2
commits into
master
Choose a base branch
from
remove-duplicate-libraries
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmoreliovlabs
force-pushed
the
remove-duplicate-libraries
branch
3 times, most recently
from
February 18, 2022 03:32
2c6a156
to
a1b912b
Compare
Vovchyk
previously approved these changes
Feb 22, 2022
josedahlquist
previously approved these changes
Feb 23, 2022
rmoreliovlabs
dismissed stale reviews from josedahlquist and Vovchyk
via
March 29, 2022 05:03
a0fcdb1
rmoreliovlabs
force-pushed
the
remove-duplicate-libraries
branch
from
March 29, 2022 05:03
a1b912b
to
a0fcdb1
Compare
VaWheel
reviewed
Mar 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please add to .gitignore the .DS_STORE files? and remove them from your PR?
rmoreliovlabs
force-pushed
the
remove-duplicate-libraries
branch
from
April 6, 2022 13:39
73bddc8
to
a987d17
Compare
Done @josedahlquist |
kelvinator07
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed duplicated classes already existing in
co.rsk:native
:core/src/main/java/org/bitcoin/NativeSecp256k1.java
core/src/main/java/org/bitcoin/NativeSecp256k1Util.java
core/src/main/java/org/bitcoin/Secp256k1Context.java