This repository has been archived by the owner on May 19, 2023. It is now read-only.
Default constructors #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## refactor-encryption-manager #55 +/- ##
===============================================================
- Coverage 84.96% 84.35% -0.62%
===============================================================
Files 18 18
Lines 379 377 -2
Branches 53 49 -4
===============================================================
- Hits 322 318 -4
- Misses 57 59 +2
Continue to review full report at Codecov.
|
javiesses
reviewed
Dec 29, 2020
| getEncryptionPublicKey: getEncryptionPublicKeyTestFn, | ||
| decrypt: decryptTestFn | ||
| }) | ||
| const message = 'Hello my name is Javi' |
javiesses
reviewed
Dec 29, 2020
| @@ -110,33 +114,41 @@ export const customStorageFactory = (): ClientKeyValueStorage => { | |||
| } | |||
| } | |||
|
|
|||
| export const setupDataVaultClient = async (serviceUrl: string, serviceDid: string): Promise<{ dataVaultClient: DataVaultWebClient, did: string }> => { | |||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | |||
There was a problem hiding this comment.
Let's remove it if we are not going to use it, then we can add it back
javiesses
approved these changes
Dec 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change: constructor now uses encryption manager and auth manager instances instead of options
Will add docs once PR is approved :)