-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PP-584 (REL-005): Add secure transfer in the Collector #100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndresQuijano the changes look good to me and we should add also some successful scenarios in the tests, to check that the transaction doesn't fail if the transfer is successful.
Furthermore, for the sake of curiosity, have we analyzed the gas consumption change of this addition? I'm wondering if not using the openzeppelin contracts but doing the checks directly would be cheaper.
As we talked before, I think the success cases are covered by previous test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor improvement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What
Why
Refs