Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US-2163 Confirmation screen fails when leaving the app #901

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

TravellerOnTheRun
Copy link
Collaborator

@TravellerOnTheRun TravellerOnTheRun commented Mar 1, 2024

@jormelCoin
Closing the request and reloading the app is expected when gracePeriod is over.
https://github.com/rsksmart/rif-wallet/assets/47615361/312a80e9-9dec-43ef-92fd-e0208d97e980

Copy link
Contributor

@jormelCoin jormelCoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @TravellerOnTheRun , I got an error alert when I perform the tests:

20240302_144848.mp4

@TravellerOnTheRun
Copy link
Collaborator Author

TravellerOnTheRun commented Mar 4, 2024

Hey @TravellerOnTheRun , I got an error alert when I perform the tests:

20240302_144848.mp4

First of all, this is not a fatal error, since it's just not being able to find the screen with this name because it does not exist if the app is unlocked. Second, it's android specific and weird as I just tried and it was showing and now I'm doing the same and it does not show(video attached). Third, the ticket was about fixing the failing Send flow, now it's not failing and allows to continue, hence I guess we can consider it fixed.
untitled.webm

@jessgusclark jessgusclark merged commit 297c719 into develop Mar 29, 2024
1 check passed
@jessgusclark
Copy link
Member

Fixed merge conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tested Ready to move forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants