Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify BlockExecutor Logic #14

Open
aeidelman opened this issue May 19, 2017 · 0 comments
Open

Simplify BlockExecutor Logic #14

aeidelman opened this issue May 19, 2017 · 0 comments

Comments

@aeidelman
Copy link
Collaborator

nitially, BlockExecutor was a simple object that runs the transactions in a block, and in other method, apply the results (root store, etc...) to fill a block. Now, the execution of the transactions is polluted by the use of flags. And it is used with different flags from different core code (miner server vs blockchain). And one flag is used to skip some "not well formed" transactions in old tests. 

We should refactor this class to have a clearer use, and improve to have test with "real and accepted and well-formed" transactions 

josedahlquist pushed a commit that referenced this issue May 3, 2018
Added helper functions to check if a tx spents p2pkh input, also impr…
nacho692 added a commit that referenced this issue Jan 8, 2020
End 1.2.0 development cycle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant