Implementation of RSKIP379 #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
marcos-iov
force-pushed
the
bridge-btc-tx-index-integration
branch
from
767dbe9
to
e96d03b
Compare
|
pipeline:run |
marcos-iov
force-pushed
the
bridge-btc-tx-index-integration
branch
from
1cfdc9c
to
aa42ace
Compare
Added tests.
…onfigsForTest helper - Got rid of sigHash parameter when testing null values - Got rid of no needed comments - Renamed BRIDGE_BTC_TX_SIG_HASH_KEY to BRIDGE_BTC_TX_SIG_HASH
- Renamed test parameter provider's methods - Added tests testing invalid stored data, considered an illegal state of the storage
…idgeBtcTxSigHashes in a single rsk tx
- Created a copy of PegTestUtils.CreateHash method into BitcoinTestUtils. - Replaced usage of PegTestUtils.CreateHash method to BitcoinTestUtils.CreateHash
Added test that assert redeemScript can be obtained from input.
Made createBaseInputScriptThatSpendsFromTheFederation and createBaseRedeemScriptThatSpendsFromTheFederation methods simpler.
Made BridgeUtils.extractRedeemScriptFromInput public. Refactored BitcoinUtils.getFirstInputSigHash and tests to get redeemscript using BridgeUtils.extractRedeemScriptFromInput.
Reorganized tests.
- Moved common init test code to a beforeEach method.
- Added new test using a real btc transaction and checking extracted sigHash against the signature. Experiment worked. - Used ScriptBuilder to get p2SHScript.
- Refactored sighash verification.
- Renamed method to extractSignaturesFromTxInput.
Improved assertions at BitcoinUtilsTest.
Refactored helper methods.
…nstance variable so no need to be creating these variables for each test that needs it. - Fix some tests
Renamed test
marcos-iov
force-pushed
the
bridge-btc-tx-index-integration
branch
from
ef66415
to
edda853
Compare
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
Kudos, SonarCloud Quality Gate passed! |
|
pipeline:run |
8 similar comments
|
pipeline:run |
|
pipeline:run |
|
pipeline:run |
|
pipeline:run |
|
pipeline:run |
|
pipeline:run |
|
pipeline:run |
|
pipeline:run |
|
pipeline:run |
2 similar comments
|
pipeline:run |
|
pipeline:run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create an index in the Bridge to store the sighash of transactions created by the Bridge. This index can then be used to simplify the detection of peg-in/peg-out/migration transactions.
fed:bridge-btc-tx-index-integration
rit:adds-tbd600-fork