Support non-WebKit browsers #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `lookupCSS` and `lookupJS' accept the non-prefixed property name and returns the supported property name. Return values are either vendor-prefixed, not-prefixed, or `false` if it's unsupported * `lookupCSS` accepts a dashed CSS property value (like `box-sizing') and `lookupJS` accepts a camel case string (like `boxSizing`). It would be trivial to implement versions which accepted multiple argument types and returned the correct value, but punting on that until it's needed. * The lookup table (for both JS and CSS values) is generated at "compile-time" based on a list of values known to be used. The `lookup*` functions could be altered to do lazy loading if desired. That approach was avoid in this initial version to avoid any run-timeperformance penalty.
FF (19, at least) does not support the individual transform-origin properties (e.g, `transform-origin-x`, `transform-origin-y`). Neither prefixed nor otherwise. Using the shorthand property gets around this limitation and, I think, could be faster because there are fewer operations.
Links were all 'undefined'. Use jQuery, in lieu of DOM methods, since we already load it in the page for XHR.
rsms
added a commit
that referenced
this pull request
May 15, 2013
Support non-WebKit browsers. Amazing work by @jfsiii.
|
I'm stoked to see this merged. Should we edit |
|
Good point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I doubt this is ready to be merged just yet, but I wanted to get a discussion going about what I've done so far.