Root-only query handling #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Previously only object and array roots were supported. Ref: #160
V0ldek
force-pushed
the
v0ldek/#160-atomic-roots
branch
from
967857a
to
81b955e
Compare
charles-paperman
approved these changes
Sep 22, 2023
zwerdlds
reviewed
Sep 22, 2023
| @@ -169,7 +180,7 @@ pub(super) mod in_slice { | |||
|
|
|||
| #[inline] | |||
| pub(super) fn pad_last_block(bytes: &[u8]) -> LastBlock { | |||
| let mut last_block_buf = [0; MAX_BLOCK_SIZE]; | |||
| let mut last_block_buf = [b' '; MAX_BLOCK_SIZE]; | |||
There was a problem hiding this comment.
I'd consider moving this to a constant, if possible.
There was a problem hiding this comment.
Though I guess for a test it's ok.
| #[inline(always)] | ||
| #[must_use] | ||
| pub(crate) fn is_json_whitespace(x: u8) -> bool { | ||
| x == b' ' || x == b'\t' || x == b'\n' || x == b'\r' |
There was a problem hiding this comment.
No opinion on perf, but legibility here might be improved with a match
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
The primary goal is to support the empty query on arbitrary JSON documents to behave as one would expect.
To facilitate that, we move the empty query special case over to a module and specialize all result modes. Most of them are really simple – asking for count is just asking if the root exists (count of 1) or not (count of 0) and can be done without looking at most of the input. All of those specializations assume valid input JSONs.
As an apropos fix, internal block padding was changed from null bytes to spaces – null bytes should not appear in a valid JSON at any point, and whitespace are properly neutral to the engine.
Issue
Resolves: #160
Checklist
All of these should be ticked off before you submit the PR.
just verifylocally and it succeeded.