Merge pull request #2479 from avit/pathnames

Allow Pathname arguments to be escaped

lib/rspec/core/shell_escape.rb

@@ -6,7 +6,7 @@ module ShellEscape
       module_function
 
       def quote(argument)
-        "'#{argument.gsub("'", "\\\\'")}'"
+        "'#{argument.to_s.gsub("'", "\\\\'")}'"
       end
 
       if RSpec::Support::OS.windows?
@@ -17,7 +17,7 @@ def quote(argument)
         require 'shellwords'
 
         def escape(shell_command)
-          shell_command.shellescape
+          Shellwords.escape(shell_command.to_s)
         end
       end
 

spec/rspec/core/bisect/runner_spec.rb

@@ -148,6 +148,15 @@ def expect_formatters_to_be_excluded
           expect(cmd).to first_include('-Il\ p/foo:l\ p/bar').then_include(RSpec::Core.path_to_executable)
         end
       end
+
+      it 'supports Pathnames in the load path' do
+        cmd = command_for([], :load_path => [Pathname('l p/foo'), Pathname('l p/bar') ])
+        if uses_quoting_for_escaping?
+          expect(cmd).to first_include("-I'l p/foo':'l p/bar'").then_include(RSpec::Core.path_to_executable)
+        else
+          expect(cmd).to first_include('-Il\ p/foo:l\ p/bar').then_include(RSpec::Core.path_to_executable)
+        end
+      end
     end
 
     describe "#repro_command_from", :simulate_shell_allowing_unquoted_ids do