Named subject can be referred from an inside subject block

Example:

    describe "list" do
      subject(:list) { [1,2,3] }
      describe 'first' do
        subject(:first_element) { list.first }
        it { should eq(1) }
      end
    end

With the previous implementation, this fails with "stack level too deep".
This error is not obvious and irritating to me.

I believe this behaviour is more natural.

Author: tomykaira

lib/rspec/core/subject.rb

@@ -193,8 +193,12 @@ def its(attribute, &block)
         # @see ExampleMethods#subject
         # @see ExampleMethods#should
         def subject(name=nil, &block)
-          define_method(name) { subject } if name
-          block ? @explicit_subject_block = block : explicit_subject || implicit_subject
+          if name
+            let(name, &block)
+            subject { instance_eval(name.to_s) }
+          else
+            block ? @explicit_subject_block = block : explicit_subject || implicit_subject
+          end
         end
 
         attr_reader :explicit_subject_block

spec/rspec/core/subject_spec.rb

@@ -91,6 +91,17 @@ module RSpec::Core
           end
           group.run.should be_true
         end
+
+        it "is referred from inside subject by the name" do
+          group = ExampleGroup.describe do
+            subject(:list) { [1,2,3] }
+            describe 'first' do
+              subject(:first_element) { list.first }
+              it { should eq(1) }
+            end
+          end
+          group.run.should be_true
+        end
       end
     end