-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rubocop cops name #222
Conversation
benoittgt
commented
Aug 24, 2019
``` bin/rubocop lib Error: The `Layout/FirstParameterIndentation` cop has been renamed to `Layout/IndentFirstArgument`. (obsolete configuration found in .rubocop_rspec_base.yml, please update it) The `Layout/IndentArray` cop has been renamed to `Layout/IndentFirstArrayElement`. (obsolete configuration found in .rubocop_rspec_base.yml, please update it) ```
I believe the error message it depends on which version of RuboCop you are using. E.g. Changing the names in this repo requires the update of RuboCop to a recent version for all RSpec repos, and to my knowledge, this is quite an effort. I'm not certain regarding other repos, but I can help with fixing those offences if you like. |
Thanks a lot for the quick answer @pirj I had the issue with rspec-rails https://travis-ci.org/rspec/rspec-rails/builds/576184591 I lock rspec-rails Rubocop to 0.52.1 to avoid too much changes. |
This is the same version as: https://github.com/rspec/rspec-expectations/blob/master/Gemfile#L65 Related: rspec/rspec-dev#222 (comment)
This is the same version as: https://github.com/rspec/rspec-expectations/blob/master/Gemfile#L65 Related: rspec/rspec-dev#222 (comment)
This is the same version as: https://github.com/rspec/rspec-expectations/blob/master/Gemfile#L65 Related: rspec/rspec-dev#222 (comment)
This is the same version as: https://github.com/rspec/rspec-expectations/blob/master/Gemfile#L65 Related: rspec/rspec-dev#222 (comment)
This is the same version as: https://github.com/rspec/rspec-expectations/blob/master/Gemfile#L65 Related: rspec/rspec-dev#222 (comment)