Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rubocop cops name #222

Closed
wants to merge 1 commit into from
Closed

Fix rubocop cops name #222

wants to merge 1 commit into from

Conversation

benoittgt
Copy link
Member

bin/rubocop lib
Error: The `Layout/FirstParameterIndentation` cop has been renamed to `Layout/IndentFirstArgument`.
(obsolete configuration found in .rubocop_rspec_base.yml, please update it)
The `Layout/IndentArray` cop has been renamed to `Layout/IndentFirstArrayElement`.
(obsolete configuration found in .rubocop_rspec_base.yml, please update it)

```
bin/rubocop lib
Error: The `Layout/FirstParameterIndentation` cop has been renamed to `Layout/IndentFirstArgument`.
(obsolete configuration found in .rubocop_rspec_base.yml, please update it)
The `Layout/IndentArray` cop has been renamed to `Layout/IndentFirstArrayElement`.
(obsolete configuration found in .rubocop_rspec_base.yml, please update it)
```
@pirj
Copy link
Member

pirj commented Aug 24, 2019

I believe the error message it depends on which version of RuboCop you are using.

E.g. rspec-expectations's rubocop dependency is locked at 0.52.1, which e.g. still has FirstParameterIndentation.

Changing the names in this repo requires the update of RuboCop to a recent version for all RSpec repos, and to my knowledge, this is quite an effort.

I'm not certain regarding other repos, but rspec-expectations is relatively clean, however, offences from newly introduced/improved cops may come up with rubocop version update.

I can help with fixing those offences if you like.

@benoittgt
Copy link
Member Author

benoittgt commented Aug 24, 2019

Thanks a lot for the quick answer @pirj

I had the issue with rspec-rails https://travis-ci.org/rspec/rspec-rails/builds/576184591

I lock rspec-rails Rubocop to 0.52.1 to avoid too much changes.

benoittgt added a commit to benoittgt/rspec-rails that referenced this pull request Aug 24, 2019
@benoittgt benoittgt closed this Aug 24, 2019
@benoittgt benoittgt deleted the fix_rubocop_name branch August 24, 2019 14:29
benoittgt added a commit to benoittgt/rspec-rails that referenced this pull request Aug 24, 2019
benoittgt added a commit to benoittgt/rspec-rails that referenced this pull request Aug 24, 2019
benoittgt added a commit to benoittgt/rspec-rails that referenced this pull request Aug 26, 2019
benoittgt added a commit to benoittgt/rspec-rails that referenced this pull request Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants