Allow custom matchers to use built-in #match #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses problem with dispatching the #match matcher from within a custom matcher. (Wow... what a mouthful) See Issue rspec#188.
|
Nice work! This looks like an appropriate fix. I think it could benefit from some docs explaining the reason |
|
Thanks. I was thinking some explanation was due as well, but I'm not quite sure where to put it. Suggestions? |
|
Maybe here and in the cuke you modified? |
|
OK, I'll add some docs tomorrow - Big Nerd Ranch holiday party starts 🔜 |
|
This looks good to me now. |
myronmarston
added a commit
that referenced
this pull request
Dec 7, 2012
…ith_match Allow custom matchers to use built-in #match
|
Thanks, @stevenharman! |
eloyesp
pushed a commit
to eloyesp/rspec-expectations
that referenced
this pull request
Nov 5, 2013
Rather than evaling the `define` block in the context of the matcher instance, eval the `define` block in the context of the matcher instance's singleton class. * Fixes rspec#272. `include` in `define` has a different meaning (module inclusion) than `include` in the `match` block (using the `include` matcher to match). * Better solution than rspec#194 for rspec#188. There's now a `match` class method and a `match` instance method. * Completely avoids issues we had to use hacks to solve before: rspec#29, rspec#38, rspec@fc4b66d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue #188.