Fix kwargs delegation warning in and_call_original
#1383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
reviewed
Dec 29, 2020
| @@ -98,7 +99,7 @@ def and_return(first_value, *values) | |||
| # expect(counter.count).to eq(original_count + 1) | |||
| def and_call_original | |||
| wrap_original(__method__) do |original, *args, &block| | |||
| original.call(*args, &block) | |||
| RSpec::Support::WithKeywordsWhenNeeded.call(original, *args, &block) | |||
There was a problem hiding this comment.
This can't be used, it causes problems with arguments that implement to_hash and this module is being phased out for removal in RSpec 4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: rspec/rspec-support#475
Fixes: #1306
Supersedes: #1324
Based on: https://github.com/rspec/rspec-mocks/pull/1324/files#diff-afc11368b62c27a5bd155b766ec9cf4e96a9331d073b6123a9bce36a270de640R359
[ ] revert changes to
Gemfilebefore merging (preferably after merging the accompanyingrspec-supportPR