Release rspec-rails 3.8.2

[fables-tales]

Given that there aren't any new features merged in to master, let's make sure we've forward-ported all the bugfixes and enhancements from master to 3-8-maintenance and release 3.8.2 so that we can then begin the process of developing RSpec Rails 4.

@benoittgt do you want to tackle this issue?

[JonRowe]

#2037 and #2057 spring to mind, and the build fixes too

[benoittgt]

For the moment we have master...3-8-maintenance

So it means:

1. Start from master then add a commit locally that move Changelog head and another commit that change version like 952cbcf ?
2. Push to 3-8-maintenance
3. Release the gem
4. Update maintenance branch file? d05d6bd
   ...

We have a good checklist but for minor versions. rspec/rspec-dev#204 I am wondering how much I could follow it for rspec-rails patch release.

[JonRowe]

My own personal check list is:

• Check out 3-8-maintenance
• Cherry pick bug fixes that aren't on 3-8-maintenance, editing changefile as necessary
• Finalise change log
• Run rake release with an account that has credentials logged in
• Ensure fully pushed to 3-8-maintenance
• Check out master and ensure change log is updated. (This could be a PR from maintenance).
• 🎉

[benoittgt]

Thanks a lot for the list.

I will probably try do it tomorrow. What do you think about including #2047?

I don't have rake release rights. Maybe the best for the first time is a PR from my fork to 3-8-mainteance so we can agree about which commits will be included into 3.8.2.

[JonRowe]

The `rake release` rights are what Sam is organising for you, so hopefully by the time you’re ready you’ll have what you need :) Jon Rowe --------------------------- mail@jonrowe.co.uk jonrowe.co.uk

…

On 12 January 2019 at 22:14, Benoit Tigeot wrote: Thanks a lot for the list. I will probably try do it tomorrow. What do you think about including #2047 (#2047)? I don't have rake release rights. Maybe the best for the first time is a PR from my fork to 3-8-mainteance so we can agree about which commits will be included into 3.8.2.

[benoittgt]

Checklist done in #2067 (comment) 🎉

Thanks a lot Sam and Jon

[fables-tales]

Yesssss

On Fri, 18 Jan 2019 at 13:41, Benoit Tigeot ***@***.***> wrote: Closed #2066 <#2066>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2066 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAF5lmD7IwogQ398fpI7oqn1E2KZ8PlXks5vEc8bgaJpZM4Z7YCL> .

-- Sam Phippen