Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify layout with render template #2063

Merged
merged 2 commits into from
Jan 11, 2019

Conversation

fables-tales
Copy link
Member

Fixes #1837
Cloes #1836

@@ -1,7 +1,7 @@
Feature: render_template matcher

The `render_template` matcher is used to specify that a request renders a
given template. It delegates to
given template or layout. It delegates to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double space after the period?

@JonRowe
Copy link
Member

JonRowe commented Jan 7, 2019

Build is red due to #2061 which I'm hoping I'm about to fix

@JonRowe
Copy link
Member

JonRowe commented Jan 9, 2019

#2061 is merged so a rebase would get this green hopefully.

@fables-tales fables-tales force-pushed the specify-layout-with-render_template branch from 8f31904 to e95c213 Compare January 10, 2019 14:09
@fables-tales fables-tales merged commit 3b297ed into master Jan 11, 2019
@fables-tales fables-tales deleted the specify-layout-with-render_template branch January 11, 2019 12:28
benoittgt pushed a commit to benoittgt/rspec-rails that referenced this pull request May 1, 2019
* Add to render_template docs: specify that a request renders a given layout

* Fix example spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants