add support for parameterized mailer when RAILS_VERSION > 5.1 #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignatiusreza
force-pushed
the
parameterized-mailer
branch
from
b0d0210
to
01fbfdb
Compare
|
Can you rebase? Sorry :) |
ignatiusreza
force-pushed
the
parameterized-mailer
branch
from
01fbfdb
to
274299a
Compare
|
no problem! rebased, but now CI failed.. seems like the base branch is also failing, so i'll rebase again later when the base branch passes.. 👍 |
|
I just merged #2123. It should help us. :) |
ignatiusreza
force-pushed
the
parameterized-mailer
branch
from
274299a
to
93e9121
Compare
|
thanks! rebased, should be ✔️ now 👍 |
ignatiusreza
force-pushed
the
parameterized-mailer
branch
from
93e9121
to
57476ac
Compare
This was referenced May 13, 2019
benoittgt
reviewed
May 13, 2019
|
closing this in favor of #2125 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rails 5.1 introduced parameterized email via rails/rails#27825.. this PR introduce support for using the recently added
have_enqueued_emailto recognize parameterized email..PS: might conflict with #2118