Skip to content

Using $ for mangled function names conflicts with jQuery #36

Closed
rivol opened this Issue Sep 30, 2012 · 2 comments

2 participants

@rivol
rivol commented Sep 30, 2012

I have a "class" function with many subfunctions inside of it. When compressing it with Slimit, the function name mangling uses $ and _ for function names which results in errors because I am using jQuery and expect $ to remain reserved for jQuery.

See the testcase at https://gist.github.com/3806569
Names of functions 52 and 53 are mangled to $ and _ which breaks jQuery usage.

$ and _ are both used by popular JS libraries (jQuery and Underscore.js) so I'd suggest not to use them for function names.

Removing those 2 chars from ID_CHARS in scope.py fixes the problem for me, but I don't know if it might have any side effects.

@rspivak rspivak was assigned Oct 2, 2012
@rspivak
Owner
rspivak commented Oct 2, 2012

Thanks for filing the issue. I'll look into it.

@rspivak
Owner
rspivak commented Mar 23, 2013

Fixed in ada895e

@rspivak rspivak closed this Mar 23, 2013
@lelit lelit pushed a commit to lelit/slimit that referenced this issue Feb 9, 2014
@rspivak Bug fix: rspivak#36 ada895e
@acatton acatton added a commit to acatton/slimit that referenced this issue Jan 26, 2015
@rspivak Bug fix: rspivak#36 1ae4284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.