You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The latest versions of Bootstrap include a layer of CSS properties that help make theming, and adapting to new themes, much easier for downstream components like DT data tables.
For instance, the popover menus for DT filters assume a light theme by default – rstudio/bslib#267 – and cannot be themed by third parties the outside due to their use of inline styles.
Where DT currently uses the following inline styles for popovers
Also the BS5 rules for DT datatables could pick up some BS5 CSS variables, namely:
--bs-table-striped-bg
--bs-table-active-bg
--bs-table-hover-bg
These would also likely help DT be more responsive to Bootstrap's new dark mode (in BS 5.3). In general, if you or anyone are exploring dark mode support (#1085), especially for the latest version of Bootstrap, I'd recommend using Bootstrap's CSS variables as much as possible.
The latest versions of Bootstrap include a layer of CSS properties that help make theming, and adapting to new themes, much easier for downstream components like DT data tables.
For instance, the popover menus for DT filters assume a light theme by default – rstudio/bslib#267 – and cannot be themed by third parties the outside due to their use of inline styles.
Where DT currently uses the following inline styles for popovers
it could instead (at least for BS5) use the following.
The text was updated successfully, but these errors were encountered: